logging: also capture logs from non-propagating loggers#14375
Open
bluetech wants to merge 2 commits intopytest-dev:mainfrom
Open
logging: also capture logs from non-propagating loggers#14375bluetech wants to merge 2 commits intopytest-dev:mainfrom
bluetech wants to merge 2 commits intopytest-dev:mainfrom
Conversation
…f non-propagating loggers Demonstrate the bug/missing functionality of reporting logs emitted by non-propagating loggers (i.e. loggers which don't reach the root logger, where we currently attach our handler). Refs pytest-dev#3697 [ran: extracted from pytest-dev#10303 and changed to use HookRecorder]
Previously, we only attached our capturing handler to the root logger. This means that logs emitted by non-propagating loggers (including all children which propagate to *them*) were not captured. As far as I can see, for the pytest use case, we do always want to capture these logs, for both test reporting (i.e. the "Captured log calls" section) and `caplog` testing. Fix by attaching to all non-propagating loggers in addition to the root logger. This approach doesn't handle loggers which become non-propagating during the test, which seems OK to me. A downside is that the (somewhat performance-sensitive) per-test logging setup becomes a bit slower (depending on the logging setup). Fix pytest-dev#3697
psf-chronographer
bot
added
the
bot:chronographer:provided
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we only attached our capturing handler to the root logger. This means that logs emitted by non-propagating loggers (including all children which propagate to them) were not captured.
As far as I can see, for the pytest use case, we do always want to capture these logs, for both test reporting (i.e. the "Captured log calls" section) and
caplogtesting.Fix by attaching to all non-propagating loggers in addition to the root logger. This approach doesn't handle loggers which become non-propagating during the test, which seems OK to me.
A downside is that the (somewhat performance-sensitive) per-test logging setup becomes a bit slower (depending on the logging setup).
Fix #3697