Open issues if PyBaMM dev and lowest-dependency tests fail

[agriyakhetarpal]

Description

This PR closes #297; it adds https://github.com/scientific-python/issue-from-pytest-log-action in order to allow opening issues from failures reported in our scheduled nightly tests. I've also bumped a number of our GitHub Actions versions, which were getting outdated.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

• No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: nox -s tests
• The documentation builds: nox -s doctest
• Code is commented for hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.83%. Comparing base (4628a65) to head (3e5c395).
⚠️ Report is 20 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #879      +/-   ##
===========================================
+ Coverage    89.41%   90.83%   +1.41%     
===========================================
  Files           63       67       +4     
  Lines         4857     5270     +413     
===========================================
+ Hits          4343     4787     +444     
+ Misses         514      483      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[agriyakhetarpal]

I am seeing the following in the workflow runs:

The action lycheeverse/lychee-action@a8c4c7cb88f0c7386610c35eb25108e448569cb0 is not allowed in pybop-team/PyBOP because all actions must be from a repository owned by pybop-team, created by GitHub, verified in the GitHub Marketplace, or match one of the patterns: lycheeverse/lychee-action@v2, openjournals/openjournals-draft-action@master, peaceiris/actions-gh-pages@v3, snok/install-poetry@v1, softprops/action-gh-release@v1, softprops/action-gh-release@v2.

Whoever has access to the repository settings, could you please update the workflow patterns to include only the action names and remove the versions? These are outdated versions, and we should be in a good position to update them now. I'd also like to add Dependabot for us in another PR, which would be useful in this scenario. Also, for extra security, we can now require actions to be pinned to their SHAs – please tick that option. Thanks!

[NicolaCourtier]

Looks good, thanks! I have updated the repository settings.

[agriyakhetarpal]

Thanks @NicolaCourtier! This should be ready to go in, let's give it a spin!

[agriyakhetarpal]

Hmm, I tried to run the workflow manually just to confirm things are alright and it looks like we need to allow one more action in the settings, as there is one more startup failure:

Error The action scientific-python/issue-from-pytest-log-action@558a3df is not allowed in pybop-team/PyBOP because all actions must be from a repository owned by pybop-team, created by GitHub, verified in the GitHub Marketplace, or match one of the patterns: lycheeverse/lychee-action@, openjournals/openjournals-draft-action@, peaceiris/actions-gh-pages@, snok/install-poetry@, softprops/action-gh-release@*. All actions must also be pinned to a full-length commit SHA.

[NicolaCourtier]

You're right, but we also need to move to the latest version of scientific-python/issue-from-pytest-log-action where they specific the full-length commit SHA for their dependency on another action.

[agriyakhetarpal]

Hmm, we're already at their latest version (v1.4.0), and https://github.com/scientific-python/issue-from-pytest-log-action/blob/main/action.yaml shows that the actions they rely on are also pinned to the SHAs. I wonder where it's coming from?

[agriyakhetarpal]

Ah, sorry, it's because their v1.4.0 release was released in September last year, but the action versions were pinned in scientific-python/issue-from-pytest-log-action#62 just last week, and that PR hasn't made it to a new release. I will ask them about creating a new release that includes those changes.

[agriyakhetarpal]

A new release is out! I opened #883 to test this out now.