Skip to content

Fix nightly workflow again#884

Merged
agriyakhetarpal merged 1 commit intopybop-team:developfrom
agriyakhetarpal:fix-nightly-workflow2
Feb 10, 2026
Merged

Fix nightly workflow again#884
agriyakhetarpal merged 1 commit intopybop-team:developfrom
agriyakhetarpal:fix-nightly-workflow2

Conversation

@agriyakhetarpal
Copy link
Copy Markdown
Member

Description

From #879 and #883: TIL that uv pip does not accept -y for "yes", it installs/uninstalls without prompting the user for input. This was missed when I changed pip to uv pip in the "latest" nightly tests.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctest
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@agriyakhetarpal
Copy link
Copy Markdown
Member Author

agriyakhetarpal commented Feb 10, 2026

Side note: we shouldn't install the dev dependencies alongside all. Instead, we should use the newer dependency groups. I'll prepare a PR for this (edit: did that with #885).

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (4628a65) to head (e97b2d6).
⚠️ Report is 23 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #884      +/-   ##
===========================================
+ Coverage    89.41%   90.93%   +1.51%     
===========================================
  Files           63       70       +7     
  Lines         4857     5361     +504     
===========================================
+ Hits          4343     4875     +532     
+ Misses         514      486      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agriyakhetarpal agriyakhetarpal merged commit 1ff7a03 into pybop-team:develop Feb 10, 2026
31 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix-nightly-workflow2 branch February 10, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants