Repository navigation
List a Pull Request No Longer Open Among Exit 0's Unregistered Cases - #3485
Merged
Merged
Conversation
The promotion review of #3484 found the help and README saying exit 0 can leave a required check unregistered only under three conditions, while a pull request no longer open is a fourth. The list now names it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The local pass found that dropping "then" let the list read as covering every exit 0, a Copilot-covered head on the default branch included. It is back, tying the list to the attested held head. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Documentation changes are consistent, behavior is unchanged, and no unresolved issues were identified.
No open issues 🎉
What changed in this PR
Updates the wait command documentation to include pull requests that are no longer open among the cases where exit 0 may leave required checks unregistered. Runtime behavior is unchanged.
Changes:
- Updates
scripts/pr_review.pyhelp text. - Updates the corresponding explanation in
scripts/README.md. - Removes the redundant statement that closed pull requests never exit
45.
| File | Description |
|---|---|
scripts/README.md |
Updates the documented exit 0 conditions for held waits. |
scripts/pr_review.py |
Updates the wait command help text with the closed pull request exception. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3485 +/- ##
========================================
Coverage 81.03% 81.03%
========================================
Files 25 25
Lines 8918 8918
========================================
Hits 7227 7227
Misses 1691 1691
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 25, 2026
ptr727
added a commit
that referenced
this pull request
Oct 26, 2026
) ## Summary Promotes the pull requests merged into develop since release 2.0.1184. - [#3483](#3483): a held `wait` exits `45` with `status=CHECKS_MISSING` where it used to exit `0` over checks that never ran. The cases are a payload with no commit matching the head, a `DIRTY` merge with no check posted, and a `DIRTY` or `BEHIND` merge whose required context is unregistered or came from another app. The `wait` help and `scripts/README.md` name each exception that stays at `0`. - [#3485](#3485): the exit-0 list in the help and README names a pull request no longer open, which this promotion's own review found missing. - [#3486](#3486): where the head's rollup holds a type the reader cannot parse, the `CHECKS_MISSING` clause and the `BLOCKED` hold's note say a required check may sit in that unread part, which this promotion's second review found missing. - [#3490](#3490): the no-check-posted cause of exit `45` is scoped to `DIRTY` in the help and README and names its remedy, which this promotion's third review found missing. - [#3491](#3491): the `wait` help and README restore the caveat that a review-present exit `0` does not poll the checks, which this promotion's fourth review found dropped. Closes #3471 ## Constituent coverage Each change this promotion carries had coverage on its own pull request into develop: | Pull request | Merged head | Coverage | | --- | --- | --- | | [#3483](#3483) | `8f29cadd` | attested local pass at the merged head, base `develop`. A Copilot round on the earlier head `ee530a4b` opened three findings, each fixed in `995ce78a` and resolved, so no Copilot round covers the merged head | | [#3485](#3485) | `275e4c8b` | attested local pass at the merged head, base `develop`, and a Copilot table on the merged head naming exactly its 2 changed files, no open findings | | [#3486](#3486) | `1f9fde03` | attested local pass at the merged head, base `develop`. A Copilot round on the earlier head `b8a74e8a` opened three findings, each fixed later on the branch and resolved, so no Copilot round covers the merged head | | [#3490](#3490) | `ba37c856` | attested local pass at the merged head, base `develop`, and a Copilot table on the merged head naming exactly its 4 changed files. Its headline's test-wording preference was declined in a comment | | [#3491](#3491) | `8c65e4d8` | attested local pass at the merged head, base `develop`, and a Copilot table on the merged head naming exactly its 2 changed files, verdict clean, no open findings | 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The promotion review of #3484 found the
waithelp andscripts/README.mdsaying exit0on an attested held head can leave a required check unregistered only under unread rules, a cut rollup, or aDRAFTmerge. A pull request no longer open can too, so the list now names it in both places, replacing the separate sentence that said such a pull request never exits45. Behavior is unchanged.Part of #3471, which the promotion pull request closes.
Pre-existing findings, not filed
scripts/README.md, the held-wait paragraph (pre-existing,style): "a cut rollup" where the help saysCHECKS TRUNCATED, and "then" following theDIRTYandBEHINDsentence, both wording the earlier text already carried.Test plan
prose_lint.py --check sentence-lengthis clean over the diff, and the pre-commit gates pass.checks_never_ran,required_unregistered,required_for, and the end ofwait, and found it complete.🤖 Generated with Claude Code