[ptr727]

Summary

Promotes the pull requests merged into develop since release 2.0.1184.

• #3483: a held wait exits 45 with status=CHECKS_MISSING where it used to exit 0 over checks that never ran. The cases are a payload with no commit matching the head, a DIRTY merge with no check posted, and a DIRTY or BEHIND merge whose required context is unregistered or came from another app. The wait help and scripts/README.md name each exception that stays at 0.

• #3485: the exit-0 list in the help and README names a pull request no longer open, which this promotion's own review found missing.

• #3486: where the head's rollup holds a type the reader cannot parse, the CHECKS_MISSING clause and the BLOCKED hold's note say a required check may sit in that unread part, which this promotion's second review found missing.

• #3490: the no-check-posted cause of exit 45 is scoped to DIRTY in the help and README and names its remedy, which this promotion's third review found missing.

• #3491: the wait help and README restore the caveat that a review-present exit 0 does not poll the checks, which this promotion's fourth review found dropped.

Closes #3471

Constituent coverage

Each change this promotion carries had coverage on its own pull request into develop:

Pull request	Merged head	Coverage
#3483	8f29cadd	attested local pass at the merged head, base develop. A Copilot round on the earlier head ee530a4b opened three findings, each fixed in 995ce78a and resolved, so no Copilot round covers the merged head
#3485	275e4c8b	attested local pass at the merged head, base develop, and a Copilot table on the merged head naming exactly its 2 changed files, no open findings
#3486	1f9fde03	attested local pass at the merged head, base develop. A Copilot round on the earlier head b8a74e8a opened three findings, each fixed later on the branch and resolved, so no Copilot round covers the merged head
#3490	ba37c856	attested local pass at the merged head, base develop, and a Copilot table on the merged head naming exactly its 4 changed files. Its headline's test-wording preference was declined in a comment
#3491	8c65e4d8	attested local pass at the merged head, base develop, and a Copilot table on the merged head naming exactly its 2 changed files, verdict clean, no open findings

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: develop
• File: .coderabbit.yaml
• Commit: f87bf62
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: bd52898a-42e4-460f-9649-3372052dc5b2

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.04%. Comparing base (0da95bc) to head (f87bf62).
⚠️ Report is 422 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3484      +/-   ##
==========================================
+ Coverage   81.00%   81.04%   +0.04%     
==========================================
  Files          25       25              
  Lines        8903     8922      +19     
==========================================
+ Hits         7212     7231      +19     
  Misses       1691     1691              

Flag	Coverage Δ
python-3.13	81.04% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

🔵 Needs a closer look

The change alters exit codes that merge-gating automation reads, and the description says no Copilot round covers the merged head of a promotion into the default branch.

2 open issues

• Document closed pull requests in exit-0 contract · New
• Document closed pull requests in wait help · New

What changed in this PR

This promotion carries pull request #3483 from develop to main. It closes #3471, where a held wait exited 0 under a DIRTY or BEHIND merge whose required checks never ran. The wait now exits 45 with status=CHECKS_MISSING for those cases, and the help and README describe each exception that still exits 0.

Changes:

• wait exits 45 on an open, attested held head that nothing holds, when its rollup is unreadable or empty, or when a DIRTY or BEHIND merge lacks a required check or has it from another app.
• pr_review_checks.py adds checks_never_ran and MERGE_UNGATED, and replaces required_unmet with required_unregistered, which reads a rollup only when it was read whole.
• required_for takes the merge states whose rules it reads, and returns nothing for a pull request that is no longer open. The help text, scripts/README.md, and tests are updated to match.

File	Description
tests/​test_pr_review.py	Adds and updates tests for exit 45, the open-state guard, the rules read limits, and the cut or unread rollup cases.
scripts/​README.md	Adds exit 45 to the exit table and rewrites the held-wait paragraph to match the new behavior.
scripts/​pr_review.py	Adds exit 45 to the wait help and the held-read logic, and changes required_for to take the merge states it reads.
scripts/​pr_review_checks.py	Adds the checks_never_ran and required_unregistered helpers and the MERGE_UNGATED set, and updates the held-check logic to use them.

_{Review effort: Lite}

[Copilot]

🔵 Needs a closer look

It changes a fleet gate's exit contract, and one moderate bug in the new exit 45 path is still unresolved.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Explain unread rollup nodes instead of reporting checks as unregistered

scripts/​pr_review_checks.py:318

A required check can be reported as unregistered when the rollup holds a context type this cannot read, because required_unregistered drops unreadable nodes before matching. Under DIRTY or BEHIND the exit then says the check never registered and points at the head or the rule, although the digest says the rollup is partly unread. When an unread node is present, say so and point the maintainer at the head commit's contexts instead. The BLOCKED hold keeps its current behavior.

2 resolved since last review

• Document closed pull requests in wait help
• Document closed pull requests in exit-0 contract

_{Review effort: Lite}

[ptr727]

Answering the previously missed finding "Explain unread rollup nodes instead of reporting checks as unregistered" at scripts/pr_review_checks.py:318: fixed in 6a1990f via #3486. Where the rollup holds a type the reader cannot parse, the CHECKS_MISSING clause names "sits in the rollup's unread part" as one more cause and its remedy leads with reading the head commit's checks and statuses, and the BLOCKED hold's CHECKS_PENDING note says the unmet check may sit there too. A rollup of only unreadable nodes is filed separately as #3488.

[Copilot]

🔵 Needs a closer look

It changes the exit codes a fleet merge gate reads, so a person should confirm the new exit-45 contract and its exceptions before approval.

No open issues 🎉

3 previously missed issues

In code that hasn't changed since last review

Qualify exit 45 as applying to DIRTY merges

scripts/​pr_review.py:150

The exit 45 entry says an empty rollup releases on any merge other than CLEAN, UNSTABLE, or HAS_HOOKS. The code holds BLOCKED, BEHIND, and DRAFT at 30, so only a DIRTY merge with no check posted exits 45. Qualify the cause with "on a DIRTY merge". Same issue in scripts/README.md line 208, whose exit 45 row needs the same qualifier.

Explain and resolve the no-check conflict before running checks

scripts/​pr_review_checks.py:314

The "no check has posted" cause ends on "until resolved" and gives no remedy, unlike the other causes. Name the conflict and the action, so the reader knows what to resolve before the head can run its checks. Same finding raised by a second reviewer, merged here.

Skip empty-reason assertion cases

tests/​test_pr_review.py:3745

assertIn(reason, ...) always passes when reason is "", and four cases in this table use "". For those cases the output text is never checked. Guard the assertion so it runs only where a reason is expected.

_{Review effort: Lite}

[ptr727]

Answering the three previously missed findings of the third round, each fixed in 578a265 via #3490:

• "Qualify exit 45 as applying to DIRTY merges" (scripts/pr_review.py:150, scripts/README.md:208): the help's exit 0 paragraph and 45 entry and the README's 45 row now scope the no-check-posted cause to DIRTY.
• "Explain and resolve the no-check conflict before running checks" (scripts/pr_review_checks.py:314): the cause now says to resolve the head's conflict with its base, and a test pins that remedy.
• "Skip empty-reason assertion cases" (tests/test_pr_review.py:3745): the table asserts a reason only where one is expected, and its exit 0 rows stay covered by their CHECKS_MISSING absence check.

[Copilot]

🔵 Needs a closer look

It changes the exit codes of a merge gate that fleet automation reads and promotes that change to main, so it needs a final human review.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Restore exit-0 caveat for checks-not-run behavior

scripts/​pr_review.py:125

The help dropped the general caveat that exit 0 does not prove the required checks ran. Exit 0 on a review present reads no rules and no check, so the sentence now implies a proof it does not give. The same gap is in scripts/README.md:202, whose exit 0 row needs the caveat restored too.

_{Review effort: Lite}

[ptr727]

Answering the fourth round's previously missed finding "Restore exit-0 caveat for checks-not-run behavior" (scripts/pr_review.py:125, scripts/README.md:202): fixed in f87bf62 via #3491. The help now says, right after its opening exit 0 line, that a review-present exit 0 does not poll the checks, so it does not prove the required checks ran, and the README's exit 0 row says the same. The help's completed-runs claim is scoped to an open attested held head, the one case that polls its runs.

[Copilot]

🔵 Needs a closer look

It adds a new wait exit code that downstream automation reads on a promotion to main, and nothing in this review shows that change is safe to approve without a maintainer.

No open issues 🎉

_{Review effort: Lite}

[ptr727]

Answering the fifth round's headline, "It adds a new wait exit code that downstream automation reads on a promotion to main, and nothing in this review shows that change is safe to approve without a maintainer": the new exit 45 is the maintainer's own decision, recorded on #3471 on 2026-10-25, and merging this promotion stays the maintainer's explicit go-ahead. Within the repository, no skill, governance file, or doc maps wait's held-head exit codes, which each feature pull request's local pass searched for, and every earlier exit keeps its meaning. A held wait that used to exit 0 over checks that never ran now exits 45 with status=CHECKS_MISSING, so a caller reading only 0 sees a non-zero exit where it previously saw a false pass. The five previously missed findings listed in this round were each answered in the comments above.