Repository navigation
fix: decode XSD attributes and preserve generated enum literals - #138
Closed
nth-bailey wants to merge 3 commits into
Closed
nth-bailey wants to merge 3 commits into
nth-bailey wants to merge 3 commits into
Conversation
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XSD attributes were copied into the IR as raw XML text, so an enum declared as
R&Drejected the instance valueR&D; namespace/QName validation and UPA could also disagree. Normalize attributes consistently, preserving character-reference whitespace and reporting malformed references instead of dropping values.Decoded quotes and controls also exposed invalid generated enum literals. Escape constants, metadata, conversion tables and parse matches using the target language’s syntax. Regeneration can change enum variant identifiers and remove duplicates that previously differed only by their XML escaping.
Validation: 326 Rust tests; strict workspace Clippy and formatting; 112 Python tests with 100% statement/branch coverage; generated enum consumers compiled and executed in all seven languages, including Rust Serde round trips. C# targets .NET 8 and was executed with .NET 10 roll-forward. Companion W3C comparisons and seven-target smoke results are recorded in the follow-up report.
Stacked on #137; keep this draft until that runtime investigation is reviewed.