Repository navigation
Integrate XML correctness fixes and sampled mixed lookup - #143
Merged
Merged
Conversation
nth-bailey
changed the base branch from
perf/xml-runtime-investigation
to
main
October 4, 2026 03:59
nth-bailey
marked this pull request as ready for review
October 4, 2026 03:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine the schema attribute/entity, generated literal, namespace URI and mixed writer fixes from #138, #140, #141 and #142 on top of #137. This provides a validated integration branch for reviewing the changes together; the registry and attribute-guard prototypes remain separate.
Validation: full gate passes with 334 Rust tests, strict fmt/Clippy, Ruff, and 115 Python tests at 100% statement/branch coverage. Fresh CLI/native probes exercise all four fixes, including mixed nil XML→JSON→XML. Bounded CType/AttrDecl/NIST corpus summaries and failure tables are identical to the earlier candidate; six existing failing groups remain.
Three alternating benchmark pairs put ordinary catalog reads flat to 1% faster and writes about 0.6–0.7% slower versus the already-optimized #137 baseline. A short integration screen retains 29%/54% improvements for distributed 64/256-tag mixed writers; #142 holds the longer comparison and cutoff/distribution controls. Tiny sensor writes differ by about 4 ns.
Report and verified raw evidence. Main is unchanged. Keep this draft until the stacked correctness/performance changes are reviewed.