Skip to content

Fix: restrict order detail price updates to current order (#607) #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rom1-B merged 1 commit into from
Sep 16, 2026
+152 −13
Merged

Fix: restrict order detail price updates to current order (#607) #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Fixed

- Order detail price and discount updates are now restricted to items of the current order

## [2.11.6] 2026-09-11

### Fixed
Expand Down
18 changes: 12 additions & 6 deletions front/order.form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@
foreach ($data as $item) {
$pluginOrderOrder_Item->updatePrice_taxfree([
'item_id' => $item['id'],
'orders_id' => (int) $_POST['plugin_order_orders_id'],
'price_taxfree' => $_POST['price_taxfree'],
]);
}
Expand All @@ -440,9 +441,10 @@
);
foreach ($data as $item) {
$pluginOrderOrder_Item->updateDiscount([
'item_id' => $item['id'],
'discount' => $_POST['discount'],
'price' => $price
'item_id' => $item['id'],
'orders_id' => (int) $_POST['plugin_order_orders_id'],
'discount' => $_POST['discount'],
'price' => $price,
]);
}
}
Expand All @@ -451,10 +453,13 @@
Html::back();
} else if (isset($_POST["update_detail_item"])) {
$pluginOrderOrder->check($_POST["plugin_order_orders_id"], UPDATE);
$orders_id = (int) $_POST["plugin_order_orders_id"];

if (isset($_POST['detail_price_taxfree'])) {
foreach ($_POST['detail_price_taxfree'] as $item_id => $price) {
$pluginOrderOrder_Item->updatePrice_taxfree([
'item_id' => $item_id,
'orders_id' => $orders_id,
'price_taxfree' => $price,
]);
}
Expand All @@ -463,9 +468,10 @@
if (isset($_POST['detail_discount'])) {
foreach ($_POST['detail_discount'] as $item_id => $discount) {
$pluginOrderOrder_Item->updateDiscount([
'item_id' => $item_id,
'discount' => $discount,
'price' => isset($_POST['detail_price_taxfree']) ? $_POST['detail_price_taxfree'][$item_id] : $_POST['detail_old_price_taxfree'][$item_id]
'item_id' => $item_id,
'orders_id' => $orders_id,
'discount' => $discount,
'price' => isset($_POST['detail_price_taxfree']) ? $_POST['detail_price_taxfree'][$item_id] : $_POST['detail_old_price_taxfree'][$item_id],
]);
}
}
Expand Down
21 changes: 14 additions & 7 deletions inc/order_item.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ public function getPricesATI($priceHT, $taxes)
}

/**
* Check that this item belongs to the given order, to prevent cross-order IDOR on deletion.
* Check that this item belongs to the given order, to prevent cross-order updates and deletions.
*
* @param int $orders_id Order ID expected to own this item
*/
Expand Down Expand Up @@ -1592,16 +1592,19 @@ public function updatePrices($order_items_id)
isset($this->input['price_taxfree'])
|| isset($this->input['plugin_order_ordertaxes_id'])
) {
$orders_id = (int) $this->fields['plugin_order_orders_id'];
$price_taxfree = $this->fields['price_taxfree'];
$iterator = $this->queryRef(
$this->fields['plugin_order_orders_id'],
$orders_id,
$this->fields['plugin_order_references_id'],
$this->fields['price_taxfree'],
$this->fields['discount']
$price_taxfree,
$this->fields['discount'],
);
foreach ($iterator as $item) {
$this->updatePrice_taxfree([
'item_id' => $item['id'],
'price_taxfree' => $this->fields['price_taxfree']
'orders_id' => $orders_id,
'price_taxfree' => $price_taxfree,
]);
}
}
Expand Down Expand Up @@ -1907,7 +1910,9 @@ public function updateAnalyticNature($post)

public function updatePrice_taxfree($post)
{
$this->getFromDB($post['item_id']);
if (!$this->getFromDB($post['item_id']) || !$this->belongsToOrder((int) $post['orders_id'])) {
return;
}

$input = $this->fields;
$discount = $input['discount'];
Expand All @@ -1927,7 +1932,9 @@ public function updatePrice_taxfree($post)

public function updateDiscount($post)
{
$this->getFromDB($post['item_id']);
if (!$this->getFromDB($post['item_id']) || !$this->belongsToOrder((int) $post['orders_id'])) {
return;
}

$input = $this->fields;
$plugin_order_ordertaxes_id = $input['plugin_order_ordertaxes_id'];
Expand Down
120 changes: 120 additions & 0 deletions tests/Units/OrderItemTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,12 @@

namespace GlpiPlugin\Order\Tests\Units;

use Computer;
use DbTestCase;
use Entity;
use PluginOrderOrder;
use PluginOrderOrder_Item;
use PluginOrderReference;

final class OrderItemTest extends DbTestCase
{
Expand All @@ -52,4 +56,120 @@ public function testBelongsToOrderReturnsFalseForForeignOrder(): void

$this->assertFalse($item->belongsToOrder(42));
}

public function testUpdatePrice_taxfreeIgnoresItemFromAnotherOrder(): void
{
global $CFG_GLPI;
$CFG_GLPI["event_loglevel"] = 0;

$this->login();

[$order_item, $foreign_orders_id] = $this->createItemInOrderAndForeignOrder();

$order_item->updatePrice_taxfree([
'item_id' => $order_item->getID(),
'orders_id' => $foreign_orders_id,
'price_taxfree' => 999,
]);

$this->assertTrue($order_item->getFromDB($order_item->getID()));
$this->assertEquals(100, (float) $order_item->fields['price_taxfree']);
}

public function testUpdatePrice_taxfreeAppliesToItemOfCurrentOrder(): void
{
global $CFG_GLPI;
$CFG_GLPI["event_loglevel"] = 0;

$this->login();

[$order_item] = $this->createItemInOrderAndForeignOrder();

$order_item->updatePrice_taxfree([
'item_id' => $order_item->getID(),
'orders_id' => (int) $order_item->fields['plugin_order_orders_id'],
'price_taxfree' => 999,
]);

$this->assertTrue($order_item->getFromDB($order_item->getID()));
$this->assertEquals(999, (float) $order_item->fields['price_taxfree']);
}

public function testUpdateDiscountIgnoresItemFromAnotherOrder(): void
{
global $CFG_GLPI;
$CFG_GLPI["event_loglevel"] = 0;

$this->login();

[$order_item, $foreign_orders_id] = $this->createItemInOrderAndForeignOrder();

$order_item->updateDiscount([
'item_id' => $order_item->getID(),
'orders_id' => $foreign_orders_id,
'discount' => 50,
'price' => 100,
]);

$this->assertTrue($order_item->getFromDB($order_item->getID()));
$this->assertEquals(0, (float) $order_item->fields['discount']);
}

public function testUpdateDiscountAppliesToItemOfCurrentOrder(): void
{
global $CFG_GLPI;
$CFG_GLPI["event_loglevel"] = 0;

$this->login();

[$order_item] = $this->createItemInOrderAndForeignOrder();

$order_item->updateDiscount([
'item_id' => $order_item->getID(),
'orders_id' => (int) $order_item->fields['plugin_order_orders_id'],
'discount' => 50,
'price' => 100,
]);

$this->assertTrue($order_item->getFromDB($order_item->getID()));
$this->assertEquals(50, (float) $order_item->fields['discount']);
$this->assertEquals(50, (float) $order_item->fields['price_discounted']);
}

/** @return array{0: PluginOrderOrder_Item, 1: int} */
private function createItemInOrderAndForeignOrder(): array
{
$entities_id = getItemByTypeName(Entity::class, '_test_root_entity', true);

$order = $this->createItem(PluginOrderOrder::class, [
'name' => 'Order test owner order',
'entities_id' => $entities_id,
'num_order' => mt_rand(),
'order_date' => date('Y-m-d'),
]);

$foreign_order = $this->createItem(PluginOrderOrder::class, [
'name' => 'Order test foreign order',
'entities_id' => $entities_id,
'num_order' => mt_rand(),
'order_date' => date('Y-m-d'),
]);

$reference = $this->createItem(PluginOrderReference::class, [
'name' => 'Order test reference',
'entities_id' => $entities_id,
'itemtype' => Computer::class,
]);

$order_item = $this->createItem(PluginOrderOrder_Item::class, [
'plugin_order_orders_id' => $order->getID(),
'plugin_order_references_id' => $reference->getID(),
'itemtype' => Computer::class,
'items_id' => 0,
'price_taxfree' => 100,
'discount' => 0,
]);

return [$order_item, (int) $foreign_order->getID()];
}
}