Fix: restrict order detail price updates to current order (#607) - #608
Merged
Merged
Conversation
Co-authored-by: Stanislas Kita <7335054+stonebuzz@users.noreply.github.com> (cherry picked from commit bd5d9f3)
Rom1-B
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit bd5d9f3)
Checklist before requesting a review
Please delete options that are not relevant.
Description
Backport for #607
When saving the detail lines of an order, the submitted price and discount values were applied to any item id received, even when that item belonged to another order.
A user editing one order could therefore alter the prices of items attached to an order they are not allowed to access.
Each submitted item is now checked against the order being edited, and lines that do not belong to it are ignored.
Screenshots (if appropriate):