Skip to content

Fix: restrict order detail price updates to current order - #607

Merged
Rom1-B merged 1 commit into
mainfrom
little_fix
Sep 15, 2026
Merged

Rom1-B merged 1 commit into
mainfrom
little_fix

Conversation

@stonebuzz

@stonebuzz stonebuzz commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • When saving the detail lines of an order, the submitted price and discount values were applied to any item id received, even when that item belonged to another order.
    A user editing one order could therefore alter the prices of items attached to an order they are not allowed to access.
    Each submitted item is now checked against the order being edited, and lines that do not belong to it are ignored.

Screenshots (if appropriate):

@stonebuzz stonebuzz self-assigned this Sep 14, 2026
@stonebuzz
stonebuzz marked this pull request as draft September 14, 2026 14:06
@stonebuzz
stonebuzz requested a review from Rom1-B September 15, 2026 07:13
@stonebuzz
stonebuzz marked this pull request as ready for review September 15, 2026 07:13
@stonebuzz
stonebuzz removed the request for review from Rom1-B September 15, 2026 08:42
@Rom1-B
Rom1-B merged commit bd5d9f3 into main Sep 15, 2026
3 checks passed
@Rom1-B
Rom1-B deleted the little_fix branch September 15, 2026 13:23
Rom1-B pushed a commit that referenced this pull request Sep 16, 2026
(cherry picked from commit bd5d9f3)

Co-authored-by: Stanislas Kita <7335054+stonebuzz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants