Skip to content

Update favicon placeholder for sites - #6671

Open
sanne-san wants to merge 3 commits into
masterfrom
sanne-favicon-placeholder
Open

Update favicon placeholder for sites#6671
sanne-san wants to merge 3 commits into
masterfrom
sanne-favicon-placeholder

Conversation

@sanne-san

@sanne-san sanne-san commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Add a placeholder with a globe on a grey tile, served for ?placeholder=site
  • Use it in the site switcher and on the sites page, where a missing favicon sits next to real ones; the reports keep the plain link icon
  • Restyle the "All sites" icon as the same tile in indigo
  • Move both site icons into components/site-icon.tsx
  • Delete the unused priv/globe_favicon.svg and GlobeIcon

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

- Add a placeholder with a globe on a grey tile, served for `?placeholder=site`
- Use it in the site switcher and on the sites page, where a missing favicon
  sits next to real ones; the reports keep the plain link icon
- Restyle the "All sites" icon as the same tile in indigo
- Move both site icons into `components/site-icon.tsx`
- Delete the unused `priv/globe_favicon.svg` and `GlobeIcon`
@github-actions

Copy link
Copy Markdown
Preview environment👷🏼‍♀️🏗️
PR-6671

@sanne-san
sanne-san force-pushed the sanne-favicon-placeholder branch from 9ec8e90 to f92d3b8 Compare September 12, 2026 05:24
@sanne-san
sanne-san added this pull request to stack #6674 September 12, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant