Skip to content

Update the favicon set to SVG with an ICO fallback - #6672

Open
sanne-san wants to merge 1 commit into
masterfrom
sanne-favicon-svg
Open

Update the favicon set to SVG with an ICO fallback#6672
sanne-san wants to merge 1 commit into
masterfrom
sanne-favicon-svg

Conversation

@sanne-san

Copy link
Copy Markdown
Contributor

Changes

  • Add a placeholder favicon.svg for both editions, so browsers that support SVG icons prefer it
  • Link the edition favicon.ico as the fallback, for Safari 18 and older
  • Delete the 16x16 and 32x32 PNGs, which the ICO now covers
  • Refresh favicon.ico and apple-touch-icon.png
  • Fill the blank favicon.ico at the site root

Noticed while working on #6671, which makes the site favicons on the sites page slightly larger.

Tests

  • This PR does not require tests

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

- Add a placeholder favicon.svg for both editions, so browsers that support
  SVG icons prefer it
- Link the edition favicon.ico as the fallback, for Safari 18 and older
- Delete the 16x16 and 32x32 PNGs, which the ICO now covers
- Refresh favicon.ico and apple-touch-icon.png
- Fill the blank favicon.ico at the site root and point the ExDoc logo at
  the new SVG

Noticed while working on #6671, which makes the site favicons on the sites
page slightly larger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant