Skip to content

fix(web): move to line edges across composer chips #11897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gigioxx wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −19
Open

fix(web): move to line edges across composer chips #11897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 14 additions & 19 deletions apps/web/src/components/ComposerPromptEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {
import { serializeComposerFileLink } from "@t3tools/shared/composerTrigger";
import {
$applyNodeReplacement,
$createRangeSelectionFromDom,
$createRangeSelection,
$getSelection,
$setSelection,
Expand Down Expand Up @@ -1089,23 +1088,22 @@ function ComposerHomeEndKeyPlugin() {
return editor.registerCommand(
KEY_DOWN_COMMAND,
(event) => {
if (!isMacPlatform(navigator.platform)) {
return false;
}
if (event.key !== "Home" && event.key !== "End") {
return false;
}
if (event.altKey || event.metaKey || event.ctrlKey || event.isComposing) {
const isCommandArrow =
isMacPlatform(navigator.platform) &&
event.metaKey &&
(event.key === "ArrowLeft" || event.key === "ArrowRight");
if (
(!isCommandArrow && event.key !== "Home" && event.key !== "End") ||
event.altKey ||
(event.metaKey && !isCommandArrow) ||
event.ctrlKey ||
event.isComposing
) {
return false;
}

const rootElement = editor.getRootElement();
const selection = window.getSelection();
const anchorNode = selection?.anchorNode;
if (!rootElement || !selection || !anchorNode || !rootElement.contains(anchorNode)) {
return false;
}
if (selection.rangeCount === 0 || typeof selection.modify !== "function") {
const selection = $getSelection();
if (!$isRangeSelection(selection) || typeof window.getSelection()?.modify !== "function") {
return false;
}

Expand All @@ -1114,12 +1112,9 @@ function ComposerHomeEndKeyPlugin() {

selection.modify(
event.shiftKey ? "extend" : "move",
event.key === "Home" ? "backward" : "forward",
event.key === "Home" || event.key === "ArrowLeft",
"lineboundary",
);
editor.update(() => {
$setSelection($createRangeSelectionFromDom(selection, editor));
});
return true;
},
COMMAND_PRIORITY_HIGH,
Expand Down
Loading