Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized composer keyboard-navigation fix that adjusts line-edge selection behavior and adds macOS Command+Arrow handling. It changes no APIs, schemas, defaults, infrastructure, or sensitive code, and its runtime scope is confined to the existing editor component. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe composer keyboard handler now supports Home and End on all platforms, plus Mac Cmd+ArrowLeft and Cmd+ArrowRight. It uses Lexical range selection state and updates line-boundary movement without DOM-to-Lexical selection synchronization. ChangesComposer navigation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge risk remains for this change. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Home and Cmd+Left stop after a leading composer chip instead of reaching the start of the line.
Use Lexical's
RangeSelection.modifyfor Home/End and macOS Cmd+Left/Right. It already handles inline decorators around the browser's visual line boundary, including Shift-selection and soft wraps. This covers skill, file, citation, and context chips in the shared web/desktop composer. The change removes five lines overall.Fixes #11892.
Verified in an isolated Chromium client: reproduced the original bug, then passed 62 selection checks and three soft-wrap scenarios. macOS shortcut checks use an overridden platform in Linux Chromium; native macOS and Windows were not run. All 73 focused composer tests, web typecheck, targeted lint, and formatting pass. Runnable browser checks are attached with the evidence.
Same prompt, immediately after Home:
Videos press Home, then type
BEFOREto show the insertion point: before / after.Model: GPT-6. Harness: Codex.
Summary by CodeRabbit