Conversation
…estore-overview/use-cases
- backup-and-restore-use-cases.md: fixed a dropped negation reversing
"at no specific time" into "at a specific time"; restored the
version-template placeholder v{{{ .tidb-version }}} that had been
hardcoded to v8.5.5 in 3 sites; fixed a severely scrambled S3
permission list (a directory reference misplaced mid-list, breaking
up 5 permission names); a dropped は after two consecutive links.
- backup-and-restore-overview.md: fixed an RPO gloss inconsistency
(two different Japanese terms for the same "Recovery Point
Objective" in one file); "log backup data" (a noun, the log-backup
feature's data) mistranslated as if "log" were a verb; a heading and
2 link texts using 回復する ("recover") instead of matching the
parallel 復元 (restore) terminology used everywhere else for this
concept; a dangling "を参照してください" with its link misplaced
earlier in the sentence; a vector-search compatibility table row
where the link and its modified noun were split apart, leaving a
dangling "で" and a nonsensical sentence.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…iles
- br-log-architecture.md: "ts" (timestamp) mistranslated as "タスク"
(task) in one site, contradicting the correct rendering used
elsewhere in the same file; an untranslated bold bullet label
("Read kv Change data") while every sibling bullet label is
translated.
- br-incremental-guide.md: a mistranslation restructured "backs up
data AND DDLs" into "data between [ts-range] and [DDLs]" as if DDLs
were a range endpoint.
- br-checkpoint-restore.md: the tool name `br` (the sentence's actual
subject) confused with a configurable "parameter" that the user must
"specify" -- invented a nonexistent option.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…e.md - Dropped "output" (出力する) verb reading as nonsensical passive "information is \`br\`-ed" - A missing opening paren left a stray closing one and a dropped particle before the NORMAL/PAUSED/ERROR status list Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…es in br-snapshot-guide.md
- A dropped clause ("superset of that in the backup data") lost its
comparison object entirely, becoming an incomplete statement.
- A link text conjugated as a complete polite-form sentence
(インストールします) instead of dictionary form, breaking the
grammar of the following 必要があります.
- A run-on sentence missing a period between two EN sentences.
- A dropped は particle before a verb.
- 3 sites where the object particle を was trapped inside a bold span
instead of following it.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…erview.md - まで (until) used instead of a purpose construction, turning "run the command to install" into "run the command until installing" - An object particle を trapped inside an <a> anchor tag instead of following it - A missing し in デプロイて (should be デプロイして) - 2 more dropped を particles found during review Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…d-line-tool.md - A dropped に particle self-contradicted the correctly-formed parallel sentence for tiup br debug's sub-commands later in the same file. - A missing opening backtick in the frontmatter summary. - A run-on sentence missing a period, inconsistent with its sibling bullet's correct punctuation. - 3 more dropped particles (を x2, が x1) found during review. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
EN uses "alert item" consistently for both the bold bullet labels and surrounding prose; JA had 警告項目 for the 6 bullet labels but アラート 項目 everywhere else. Unified on アラート項目 (the prose majority). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…p-and-restore-storages.md - Bold span folded "for backup and restore" into "access key" as a modifier, changing which method the sentence describes, and diverging from the method's own title used elsewhere in the file. - A scrambled intro sentence duplicating "external storage services" awkwardly instead of listing the three things being introduced. - A severely scrambled minimum-privileges bullet (TiKV/BR subject displaced, an HTML entity artifact, permission names broken up by misplaced clauses), rebuilt to match its correctly-formed sibling bullet right below it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…atch-create-table.md - A dropped を before ご覧ください - A sentence ending abruptly on a bare value with no copula (です) - A severely scrambled sentence where \`tikv_count\` was severed from its division formula and misplaced at the sentence end Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…nt-backup.md Restored a missing opening backtick in the frontmatter summary, and fixed 8 sites (nearly every paragraph in the file) where は/が/を was dropped right after \`br\` or \`gcttl\`, a systemic pattern across this directory. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… 2 br files
- br-snapshot-architecture.md: duplicated "TiDB" before a link
("TiDB [TiDB GCメカニズム]").
- br-snapshot-manual.md: a dropped "コマンド" (br command-line tool ->
br line tool), an unclosed parenthesis, and 4 dropped particles
(は x3, を x1) found while fixing the above.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates Japanese BR documentation. It clarifies backup, restore, PITR, compatibility, permissions, monitoring, and command descriptions. It also corrects wording, links, formatting, and version templates. ChangesBR documentation updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~10 minutes Change: Other Merge Risk: 🟡 Moderate · up to Incorrect Japanese guidance can lead operators to configure invalid S3 permissions or misunderstand restore compatibility and command syntax, so these documentation fixes should be completed before merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Revise the earlier RPO gloss fix (リカバリポイント目標) to 目標復旧時点, matching the more widely established pairing used across tidb-cloud/backup-and-restore.md, tidb-cloud/backup-and-restore-concepts.md, tidb-cloud/serverless-high-availability.md, and faq/backup-and-restore-faq.md, all of which render RTO as 目標復旧時間 and RPO as 目標復旧時点 together. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 14c9f0e4-7453-47d9-b747-88f463ce891b
📒 Files selected for processing (15)
br/backup-and-restore-overview.mdbr/backup-and-restore-storages.mdbr/backup-and-restore-use-cases.mdbr/br-batch-create-table.mdbr/br-checkpoint-backup.mdbr/br-checkpoint-restore.mdbr/br-incremental-guide.mdbr/br-log-architecture.mdbr/br-monitoring-and-alert.mdbr/br-pitr-guide.mdbr/br-snapshot-architecture.mdbr/br-snapshot-guide.mdbr/br-snapshot-manual.mdbr/br-use-overview.mdbr/use-br-command-line-tool.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
| 2. BRとTiKVがS3ディレクトリにアクセスするための権限を設定します。S3バケットにアクセスする最も安全な方法であるIAMメソッドを使用して権限を付与することをお勧めします。詳細な手順については、 [AWS ドキュメント: ユーザーポリシーによるバケットへのアクセスの制御](https://docs.aws.amazon.com/AmazonS3/latest/userguide/walkthrough1.html)を参照してください。必要な権限は次のとおりです。 | ||
|
|
||
| - バックアップ クラスター内の TiKV とBRには`s3:GetObject` `s3://tidb-pitr-bucket/backup-data`ディレクトリ`s3:DeleteObject` `s3:ListBucket` 、および`s3:PutObject` `s3:AbortMultipartUpload`権限が必要です。 | ||
| - バックアップクラスター内のTiKVとBRには、 `s3://tidb-pitr-bucket/backup-data`ディレクトリの`s3:ListBucket`、 `s3:GetObject`、 `s3:DeleteObject`、 `s3:PutObject`、および`s3:AbortMultipartUpload`権限が必要です。 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use the bucket resource for s3:ListBucket.
s3:ListBucket is a bucket-level action. Restrict backup-data/ with the s3:prefix condition. The other actions require object resources. An object-scoped s3:ListBucket statement can leave backup or restore access denied. Apply the same distinction to the restore-cluster line.
Apply this replacement
- - バックアップクラスター内のTiKVとBRには、 `s3://tidb-pitr-bucket/backup-data`ディレクトリの`s3:ListBucket`、 `s3:GetObject`、 `s3:DeleteObject`、 `s3:PutObject`、および`s3:AbortMultipartUpload`権限が必要です。
- - 復元クラスター内の TiKV とBRには、 `s3://tidb-pitr-bucket/backup-data`ディレクトリの`s3:ListBucket`と`s3:GetObject`権限が必要です。
+ - バックアップクラスター内の TiKV と BR には、`tidb-pitr-bucket` バケットに対して `s3:prefix` 条件で `backup-data/` プレフィックスに制限した `s3:ListBucket` 権限と、`s3://tidb-pitr-bucket/backup-data/` 配下のオブジェクトに対する `s3:GetObject`、`s3:DeleteObject`、`s3:PutObject`、および `s3:AbortMultipartUpload` 権限が必要です。
+ - 復元クラスター内の TiKV と BR には、`tidb-pitr-bucket` バケットに対して `s3:prefix` 条件で `backup-data/` プレフィックスに制限した `s3:ListBucket` 権限と、`s3://tidb-pitr-bucket/backup-data/` 配下のオブジェクトに対する `s3:GetObject` 権限が必要です。| ``` | ||
|
|
||
| テスト結果から、1つの TiKV インスタンスを復元する平均速度は 181.65 MB/秒 ( `average-speed`に相当) であること`tikv_count`わかります。 | ||
| テスト結果から、1つの TiKV インスタンスを復元する平均速度は 181.65 MB/秒（ `average-speed`/`tikv_count`に相当）であることがわかります。 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
#!/bin/bash
set -e
printf '%s\n' '--- target context ---'
cat -n br/br-batch-create-table.md | sed -n '45,75p'
printf '%s\n' '--- average-speed references ---'
rg -n -i --glob '*.md' --glob '*.yaml' --glob '*.yml' --glob '*.json' 'average-speed|2\.661GB/s|181\.65|tikv_count' . | head -200Repository: pingcap/docs
Length of output: 4173
🤖 get_repo_knowledge executed:
get_repo_knowledge pingcap/docs /tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c/conventions
Length of output: 1294
🌐 Web query:
TiDB BR collector.go average-speed humanize 2.661GB/s unit implementation
💡 Result:
<search_synthesis>
In TiDB's Backup & Restore (BR) tool, the average-speed reported in logs is calculated in the collector.go file [1][2]. The implementation computes the speed by dividing the total data size (TotalBytes) by the total duration of the operation (totalDureTime), and then formats the result using a humanize utility [1][2]. The relevant code snippet typically looks like this: zap.String("average-speed", units.HumanSize(float64(data)/totalDureTime.Seconds)+"/s") This implementation uses the HumanSize function from a Go units package (often github.com/dustin/go-humanize or a similar internal utility) to convert the calculated float64 value (bytes per second) into a human-readable format such as "2.661GB/s" [1][2]. The value 2.661GB/s is a representation of the throughput derived from the total transferred bytes divided by the elapsed time [1][2]. Historical issues, such as GitHub issue pingcap/br#1405, have addressed accuracy concerns regarding how this average speed is computed, ensuring that the total time taken includes all relevant phases of the backup or restore process (such as checksumming) rather than just the core data transfer time [3][4].
</search_synthesis>
<source_evidence>
Citations:
- 1: https://seaxiang.com/blog/55ced6c4ee23491881c5e94100d61b65
- 2: https://m.seaxiang.com/blog/55ced6c4ee23491881c5e94100d61b65
- 3: GitHub issue 1405 in pingcap/br (link omitted to avoid creating a cross-reference)
- 4: GitHub issue 486 in pingcap/br (link omitted to avoid creating a cross-reference)
🌐 Web query:
site:github.com/pingcap/br v6.0.0 pkg/summary/collector.go github.com/docker/go-units HumanSize average-speed
💡 Result:
<search_synthesis>
I can’t directly answer “v6.0.0 pkg/summary/collector.go github.com/docker/go-units HumanSize average-speed” as a single coherent statement without knowing which specific repository/version “v6.0.0” refers to and what you want (e.g., the exact code snippet for average-speed logging, or how HumanSize formats it). What I can say from the sources I found is that “average-speed” in a Go collector for backup/restore is computed from total size divided by a measured “real time” duration, and there were known bugs where the computed average speed was incorrect. For example, an issue describes that the expected rate should be computed by totalKVSize / realTimeTake, but the logs showed an incorrect average-speed value (2.424MB/s instead of ~680MB/s) [1]. Another issue describes “Full restore success summary” logging an “average-speed=584.5kB/s” field in collector.go output [2]. Additionally, in that same codebase, the PRs clarify summary field semantics: the restore summary’s “size” corresponds to “restore data size(after decompressed)”, and “data-size” was renamed to “total-kv-size” [3]. A separate PR (“summary: add real time cost to log collector”) indicates the collector was updated to include real time cost [4]. If you tell me: 1) which exact GitHub repo/tag “v6.0.0” is from, 2) whether you want the formula used for average-speed in pkg/summary/collector.go, 3) whether you want how docker/go-units HumanSize is applied to that value, …I can re-run targeted searches to locate the exact collector.go implementation for that version and provide a precise, code-referenced answer.
</search_synthesis>
<source_evidence>
Citations:
- 1: GitHub issue 1405 in pingcap/br (link omitted to avoid creating a cross-reference)
- 2: GitHub issue 1270 in pingcap/br (link omitted to avoid creating a cross-reference)
- 3: GitHub pull request 1132 in pingcap/br (link omitted to avoid creating a cross-reference)
- 4: GitHub pull request 486 in pingcap/br (link omitted to avoid creating a cross-reference)
Use the decimal per-instance speed.
BR formats average-speed with decimal prefixes, so 2.661GB/s ÷ 15 is approximately 177.4 MB/s. 181.65 is not supported by the logged value, and changing the unit to MiB/s would not correct the calculation.
Suggested replacement
Suggested change
| テスト結果から、1つの TiKV インスタンスを復元する平均速度は 181.65 MB/秒（ `average-speed`/`tikv_count`に相当）であることがわかります。 | |
| テスト結果から、1つの TiKV インスタンスを復元する平均速度は約 177.4 MB/秒（ `average-speed`/`tikv_count`に相当）であることがわかります。 |
Source: Path instructions
| 3. ログバックアップオブザーバーは、KVの変更ログを継続的にバックアップします。 | ||
|
|
||
| - **Read kv Change data** : KV 変更データを読み取り、変更ログ[カスタム形式でバックアップファイル](#log-backup-files)に保存します。 | ||
| - **KV変更データの読み取り**：KV 変更データを読み取り、変更ログ[カスタム形式でバックアップファイル](#log-backup-files)に保存します。 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix the Japanese sentence and link phrase.
The source statement says that the change log is saved to backup files in custom format. Add を after 変更ログ and use カスタム形式のバックアップファイル as the linked noun phrase.
Suggested change
| - **KV変更データの読み取り**：KV 変更データを読み取り、変更ログ[カスタム形式でバックアップファイル](#log-backup-files)に保存します。 | |
| - **KV変更データの読み取り**：KV 変更データを読み取り、変更ログを[カスタム形式のバックアップファイル](`#log-backup-files`)に保存します。 |
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - **KV変更データの読み取り**：KV 変更データを読み取り、変更ログ[カスタム形式でバックアップファイル](#log-backup-files)に保存します。 | |
| - **KV変更データの読み取り**：KV 変更データを読み取り、変更ログを[カスタム形式のバックアップファイル](#log-backup-files)に保存します。 |
| - ターゲットクラスタは、バックアップデータと同じシステムテーブルを持っています。 | ||
| - 対象クラスタのシステム権限テーブルの**列数は**、バックアップデータの列数と同じです。列の順序は重要ではありません。 | ||
| - 対象クラスタのシステム権限テーブルの列は、バックアップデータの列と互換性があります。列のデータ型が長さを持つ型（整数や文字列など）の場合、対象クラスタの長さはバックアップデータの長さ以上でなければなりません。列のデータ型が`ENUM`型の場合、対象クラスタの`ENUM`値の数のスーパーセットでなければなりません。 | ||
| - 対象クラスタのシステム権限テーブルの列は、バックアップデータの列と互換性があります。列のデータ型が長さを持つ型（整数や文字列など）の場合、対象クラスタの長さはバックアップデータの長さ以上でなければなりません。列のデータ型が`ENUM`型の場合、対象クラスタの`ENUM`値の数は、バックアップデータの`ENUM`値の数のスーパーセットでなければなりません。 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Describe ENUM compatibility as value-set containment.
BR’s utils.IsTypeCompatible checks that every backup ENUM value exists in the target value set. A target count that is only greater than or equal to the backup count is not sufficient.
Suggested change
| - 対象クラスタのシステム権限テーブルの列は、バックアップデータの列と互換性があります。列のデータ型が長さを持つ型（整数や文字列など）の場合、対象クラスタの長さはバックアップデータの長さ以上でなければなりません。列のデータ型が`ENUM`型の場合、対象クラスタの`ENUM`値の数は、バックアップデータの`ENUM`値の数のスーパーセットでなければなりません。 | |
| - 対象クラスタのシステム権限テーブルの列は、バックアップデータの列と互換性があります。列のデータ型が長さを持つ型（整数や文字列など）の場合、対象クラスタの長さはバックアップデータの長さ以上でなければなりません。列のデータ型が`ENUM`型の場合、対象クラスタの`ENUM`値は、バックアップデータの`ENUM`値のスーパーセットでなければなりません。 |
| --- | ||
| title: br Command-line Manual | ||
| summary: br` コマンドラインツールは、TiDB クラスターのスナップショットバックアップ、ログバックアップ、およびポイントインタイムリカバリ (PITR) に使用されます。サブコマンド、オプション、およびパラメータで構成されており、PD サービスアドレスの `--pd` やストレージパスの `-s` などの共通オプションがあります。サブコマンドには、それぞれ特定の機能を持つ `tiup br backup`、`tiup br log`、`tiup br restore` などがあります。バックアップコマンドには `full`、`db`、`table` オプションがあり、ログバックアップおよびリストアコマンドには、バックアップ操作を管理するためのさまざまなタスクがあります。 | ||
| summary: `br` コマンドラインツールは、TiDB クラスターのスナップショットバックアップ、ログバックアップ、およびポイントインタイムリカバリ (PITR) に使用されます。サブコマンド、オプション、およびパラメータで構成されており、PD サービスアドレスの `--pd` やストレージパスの `-s` などの共通オプションがあります。サブコマンドには、それぞれ特定の機能を持つ `tiup br backup`、`tiup br log`、`tiup br restore` などがあります。バックアップコマンドには `full`、`db`、`table` オプションがあり、ログバックアップおよびリストアコマンドには、バックアップ操作を管理するためのさまざまなタスクがあります。 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Call full, db, and table subcommands.
The summary calls these tokens “オプション”, but the page defines them as “サブコマンド”. This mismatch can lead readers to construct commands incorrectly. Apply this replacement:
Suggested change
| summary: `br` コマンドラインツールは、TiDB クラスターのスナップショットバックアップ、ログバックアップ、およびポイントインタイムリカバリ (PITR) に使用されます。サブコマンド、オプション、およびパラメータで構成されており、PD サービスアドレスの `--pd` やストレージパスの `-s` などの共通オプションがあります。サブコマンドには、それぞれ特定の機能を持つ `tiup br backup`、`tiup br log`、`tiup br restore` などがあります。バックアップコマンドには `full`、`db`、`table` オプションがあり、ログバックアップおよびリストアコマンドには、バックアップ操作を管理するためのさまざまなタスクがあります。 | |
| summary: `br` コマンドラインツールは、TiDB クラスターのスナップショットバックアップ、ログバックアップ、およびポイントインタイムリカバリ (PITR) に使用されます。サブコマンド、オプション、およびパラメータで構成されており、PD サービスアドレスの `--pd` やストレージパスの `-s` などの共通オプションがあります。サブコマンドには、それぞれ特定の機能を持つ `tiup br backup`、`tiup br log`、`tiup br restore` などがあります。バックアップコマンドには `full`、`db`、`table` サブコマンドがあり、ログバックアップおよびリストアコマンドには、バックアップ操作を管理するためのさまざまなタスクがあります。 |
Source: Path instructions
| ## `br`コマンドラインの説明 {#br-command-line-description} | ||
|
|
||
| `br`コマンドは、サブコマンド、オプション、パラメータで構成されます。サブコマンドとは、 `-`または`--`含まない文字です。オプションとは、 `-`または`--`で始まる文字です。パラメータとは、サブコマンドまたはオプションの直後に続く文字で、サブコマンドまたはオプションに渡されます。 | ||
| `br`コマンドは、サブコマンド、オプション、パラメータで構成されます。サブコマンドとは、 `-`または`--`を含まない文字です。オプションとは、 `-`または`--`で始まる文字です。パラメータとは、サブコマンドまたはオプションの直後に続く文字で、サブコマンドまたはオプションに渡されます。 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Describe command components as strings, not characters.
The changed definition uses 文字, but backup, --pd, and their values are multi-character tokens. Use 文字列 so the definition matches the examples and the command syntax.
Suggested change
| `br`コマンドは、サブコマンド、オプション、パラメータで構成されます。サブコマンドとは、 `-`または`--`を含まない文字です。オプションとは、 `-`または`--`で始まる文字です。パラメータとは、サブコマンドまたはオプションの直後に続く文字で、サブコマンドまたはオプションに渡されます。 | |
| `br`コマンドは、サブコマンド、オプション、パラメータで構成されます。サブコマンドとは、`-`または`--`を含まない文字列です。オプションとは、`-`または`--`で始まる文字列です。パラメータとは、サブコマンドまたはオプションの直後に続き、サブコマンドまたはオプションに渡される文字列です。 |
Source: Path instructions
Matches the "value + unit/time-unit" suffix style already used for the sibling MB/秒 and GiB/秒 rates in the same file, rather than leaving the literal EN abbreviation "h" unstyled. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…tool.md An unquoted YAML summary value starting with a backtick breaks the website-docs HTML build (confirmed on PR pingcap#23824). The earlier fix in this PR restored the missing opening backtick but left the value unquoted; wrap the whole value in double quotes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The file predominantly uses パラメータ (no long vowel, 5+ occurrences including the frontmatter summary); 3 sites used パラメーター instead. Unified on the dominant form. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…-command-line-tool.md Per the standing no-space-between-katakana convention: "PD サービス アドレス" unified to "PDサービスアドレス" (3 different spacings existed across the file), plus "クラスター データ" and "リスニング アドレス" each collapsed to a single compound. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Fixes defects found during a full-corpus JA-vs-EN review of
br/(batch 4 of the ongoing review campaign, 15 files/~62 sites). Highlights:Meaning-changing mistranslations:
backup-and-restore-use-cases.md: a dropped negation reversed "at no specific time" into "at a specific time"; the version-template placeholderv{{{ .tidb-version }}}had been hardcoded tov8.5.5in 3 sites, breaking the site's version-templating mechanism; a severely scrambled S3 permission list (a directory reference misplaced mid-list, breaking up 5 permission names)backup-and-restore-overview.md: an RPO gloss inconsistency (two different Japanese terms for "Recovery Point Objective" in one file); "log backup data" (a noun, the log-backup feature's data) mistranslated as if "log" were a verb; a heading and 2 link texts using 回復する ("recover") instead of the parallel 復元 (restore) terminology used everywhere else; a vector-search compatibility table row where the link and its modified noun were split apart, leaving a dangling particle and a nonsensical sentencebr-log-architecture.md: "ts" (timestamp) mistranslated as "タスク" (task), contradicting the correct rendering used elsewhere in the same filebr-incremental-guide.md: a mistranslation restructured "backs up data AND DDLs" into "data between [ts-range] and [DDLs]" as if DDLs were a range endpointbr-checkpoint-restore.md: the tool namebr(the sentence's actual subject) confused with a configurable "parameter" that must be "specified" -- invented a nonexistent optionbr-pitr-guide.md: a dropped "output" verb reading as nonsensical passive "information isbr-ed"br-snapshot-guide.md: a dropped clause ("superset of that in the backup data") lost its comparison object entirely, becoming an incomplete statementbr-use-overview.md: まで (until) used instead of a purpose construction, turning "run the command to install" into "run the command until installing"backup-and-restore-storages.md: a bold span folded "for backup and restore" into "access key" as a modifier, changing which method the sentence describesOther real defects:
br-batch-create-table.md: a sentence ending abruptly with no copula; a severely scrambled formula sentencebr-monitoring-and-alert.md: 警告項目/アラート項目 terminology inconsistency for "alert item" (6 sites)use-br-command-line-tool.md: a dropped に particle that self-contradicted a parallel sentence later in the file; a missing opening backtick in the frontmatterbr-snapshot-manual.md: a dropped "コマンド" word ("br command-line tool" -> "br line tool"); an unclosed parenthesisbr-snapshot-architecture.md: a duplicated "TiDB" before a linkbr-checkpoint-backup.md(nearly every paragraph)All fixes were individually re-verified against the live file and the EN source (
upstream/release-8.5) before being applied.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit