Conversation
Fixes defects found during the full-corpus JA review of tiproxy/ and faq/ (batch 6), including several severe false-friend mistranslations: "PD" (Placement Driver) glossed as Parkinson's disease, "common hotspots" as a hot pot dish, "Go" the language as "to go", a version number turned into a calendar date, and "drains clients" reversed into "client load increases". Also fixes a reversed information_schema/ create_time containment relation, a severely scrambled DDL-type table row, several garbled "possible values" config lists, dropped clauses, duplicated/orphaned text fragments, and same-file register inconsistencies (サーバ/サーバー). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughChangesDocumentation corrections
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: 🔵 Low · up to Readers may misunderstand these FAQ and deployment instructions, but the issues are limited to documentation and do not affect runtime behavior. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 0f612b2f-0206-44d5-9678-332b57d9abdf
📒 Files selected for processing (14)
faq/backup-and-restore-faq.mdfaq/deploy-and-maintain-faq.mdfaq/manage-cluster-faq.mdfaq/migration-tidb-faq.mdfaq/sql-faq.mdfaq/tidb-faq.mdfaq/upgrade-faq.mdtiproxy/tiproxy-command-line-flags.mdtiproxy/tiproxy-configuration.mdtiproxy/tiproxy-deployment-topology.mdtiproxy/tiproxy-grafana.mdtiproxy/tiproxy-load-balance.mdtiproxy/tiproxy-overview.mdtiproxy/troubleshoot-tiproxy.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
Per CodeRabbit review on pingcap#23882: fix the reversed "バージョンschema" word order (should be "schemaバージョン", matching EN's "schema version" and a sibling bullet already using the correct order in the same Note block), and remove the incorrect "コミットした" (already committed) qualifier before a transaction that is being rolled back, which contradicted itself (a committed transaction cannot be rolled back). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Change a heading's Japanese corner-bracket quoting of a literal error message to a backtick code span, matching the sibling heading right above it and the body text's own formatting for the same string. Also fix an unnatural word order around "SELECT VERSION()'s return value" that read ambiguously without a connecting particle. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Replace 役に立たない ("useless", a fairly blunt word choice for a
field name in JA technical writing) with 効果のない ("has no effect"),
which conveys the same meaning as EN's "Useless fields" without the
harsher tone.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Minor · Repair the Reorg DDL table row.
faq/sql-faq.md:254
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winRepair the Reorg DDL table row.
ADD INDEXandMODIFY COLUMNrun together, and the row has an unmatched opening parenthesis. This makes the operation examples ambiguous.Proposed wording
| 再編成DDL（`ADD INDEX`、`MODIFY COLUMN`（再編成タイプのデータ変更）など） | データ量、システム負荷、DDL パラメータ設定によって異なります。 |As per path instructions, this deterministic replacement is provided as proposed wording because Line 254 is outside the shown changed ranges.
Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 274212c9-c544-4ae5-b42f-1abff58b297a
📒 Files selected for processing (1)
faq/sql-faq.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
Grafana panel/row names are literal dashboard-JSON strings (verified against pingcap/tiproxy's tiproxy_summary.json) and must stay in English, matching EN's own text and the established ja-grafana-panel-names-english campaign convention. Restores all 5 section headings and 22 panel-name bullet labels in this file that had been translated into Japanese. Also fixes 5 sites with a dropped は particle right after a backtick example value, one fullwidth/halfwidth colon inconsistency, an unnatural connector-name translation in tiproxy-overview.md's connector table (MySQLコネクタ/Node.js -> MySQL Connector/Node.js, matching sibling literal connector names in the same table), and a confusingly-phrased sentence about prepared statement invalidation that read as an unconditional consequence rather than a coincidental state. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The Disconnection OPM panel's reason labels (success, client network
break, auth fail, etc.) are literal strings returned by TiProxy's Go
source (pkg/proxy/backend/error.go) and shown verbatim as the
Disconnection OPM panel's legend values ({{type}}) in Grafana -- not
descriptive prose to translate. Restores all 11 labels to literal
English, keeping the Japanese explanation after each colon.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Match the parallel "proxy error: その他の TiProxy エラー" line right below it -- both describe the same "not otherwise categorized" catch- all bucket in the source (SrcClientSQLErr / SrcProxyErr), so they should read the same way in Japanese. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 participant
What is changed, added or deleted? (Required)
Fixes defects found during a full-corpus JA-vs-EN review of
tiproxy/andfaq/(batch 6 of the ongoing review campaign). Highlights:Severe false-friend mistranslations (changes meaning entirely):
faq/manage-cluster-faq.md: "PD" (Placement Driver) glossed as "パーキンソン病" (Parkinson's disease) in a section introfaq/sql-faq.md: "common hotspots" mistranslated as "一般的な鍋料理" (a common hot pot dish)tiproxy/tiproxy-overview.md: connector table version5.1.19mistranslated into a calendar date "2019年5月1日"; language name "Go" mistranslated as "行く" (the verb "to go"); connector name "MySQL Connector/Node.js" partially translated as "MySQLコネクタ/Node.js"tiproxy/tiproxy-grafana.md: Grafana panel/row names mistranslated throughout the file (see below)faq/manage-cluster-faq.md: "guarantee data safety" mistranslated as "guarantee data's Raft-ness"; a reversedinformation_schema/create_timecontainment relationtiproxy/tiproxy-configuration.md: "drains clients" mistranslated as "client load increases" (the opposite claim)Grafana panel/row names restored to literal English (
tiproxy/tiproxy-grafana.md):Verified against the real dashboard JSON (
pingcap/tiproxy'spkg/metrics/grafana/tiproxy_summary.json) and TiProxy's Go source (pkg/proxy/backend/error.go). Restores 5 section headings, 22 panel-name bullet labels, and 11Disconnection OPMreason labels (success,client network break,auth fail, etc. — literal strings returned by the Go source and shown verbatim as the panel's legend values) that had all been translated into Japanese.Other real mistranslations / content defects:
faq/sql-faq.md: a "General DDL" table row severely scrambled (dropped row header, misattached qualifier); a spurious invented "version 5";SELECT FOR UPDATEsubject misplaced mid-verb; reversedschema/version word order (2 sites); a heading's quote-mark style inconsistent with its sibling heading; unnatural word order around "SELECT VERSION()'s return value"faq/backup-and-restore-faq.md: a dropped version number (v7.1.0); orphaned closing quote marks in 3 headings; a tilde (～) misused in place of theをparticle; a droppedをparticletiproxy/tiproxy-load-balance.md: dropped "by querying its error count" mechanismtiproxy/tiproxy-overview.md: a scope-generalization error (EN's "by scaling out" modifies only one of two options); a stray inserted "エラーコード" (error code) phrase; a confusingly-phrased sentence about prepared-statement invalidation that read as an unconditional consequencetiproxy/tiproxy-configuration.md(4 sites) andtiproxy/tiproxy-command-line-flags.md(1 site)auto-certsconfig field,haTOML sectionfaq/migration-tidb-faq.md,tiproxy/tiproxy-deployment-topology.md("TiUPTiUP" + dropped "cluster"),faq/tidb-faq.md(stray leading "TiDB")tiproxy/tiproxy-grafana.mdandtiproxy/tiproxy-load-balance.md; duplicated "照合順序" infaq/sql-faq.md; a blunt word choice (役に立たない -> 効果のない) for a config-field descriptionを参照してくださいtruncated to bare参照。(9 sites acrossfaq/sql-faq.md,faq/tidb-faq.md,faq/deploy-and-maintain-faq.md)はparticle right after a backtick example value intiproxy/tiproxy-grafana.mdAll fixes were individually re-verified against the live file and the EN source (
upstream/release-8.5) before being applied.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit