Conversation
The lightning_idle_workers metric's label descriptions used "the remainder of X", while the identical value is described in this same document's Grafana panel table (Row 4: Quota, Idle workers) as "Number of unused X" -- both trace back to the same Chinese source wording (未使用的 X 的数量), so this was just inconsistent EN phrasing, not an intentional distinction. Unify on "Number of unused X". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe ChangesMetric Documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to This documentation-only update does not affect runtime behavior and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…htning metrics reference
- Restore the Prometheus label keys type/name/state/result as literal
English (they were translated to タイプ/名前/状態/結果, but these are
the actual label keys used in the real metric, e.g.
lightning_importer_engine{type="open"}).
- Unify the table/index/region/io idle-worker descriptions from
'`X`の余り' to '未使用の数は`X`', matching this same document's
Grafana panel table wording for the identical value (see
pingcap#23881, which unifies the English source the same way).
- Translate the lightning_import_seconds description, which had been
left as raw, untranslated English.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Revert the table/index/region/io description wording change from the previous commit. The English source fix (pingcap#23881) hasn't merged yet, and this wording will be picked up automatically by the regular EN-to-JA sync once it does, rather than hand-applied here ahead of it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
What is changed, added or deleted? (Required)
tidb-lightning/monitor-tidb-lightning.mddescribes thelightning_idle_workersgauge'snamelabel values twice in the same document:Number of unused \table-concurrency`, normally 0 until the end of process`lightning_idle_workerslabels):the remainder of \table-concurrency`, normally 0 until the end of the process`Both describe the exact same value (the trailing clause is otherwise identical, word for word, for all 4 labels:
table/index/region/io). Checked against the Chinese source (docs-cn/tidb-lightning/monitor-tidb-lightning.md), which uses the identical phrase未使用的 X 的数量("number of unused X") in both places — so this is not an intentional distinction, just inconsistent EN wording introduced independently in two different PRs (#1455 and #1535) by the same author, 15 days apart, back in 2019.This PR unifies the metrics-reference wording to match the already-established Grafana-table phrasing (
Number of unused X), and drops the stray "the" in "until the end of the process" to exactly match the Grafana table's "until the end of process" for full consistency.This will also let the Japanese translation express both sites the same way, instead of forcing two different Japanese renderings ("未使用の数" vs "の余り") for what is the same underlying value.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit
lightning_idle_workersmetric reports unused workers for table, index, region, and I/O operations.