Conversation
…Lightning monitoring doc Panel, series, and row-name labels in the Grafana dashboard tables were translated into Japanese, making them impossible to match against the real dashboard UI. Restore them as literal English (verified against the live TiDB Lightning Grafana dashboard JSON) and translate the one Description cell that had been left as raw, untranslated English. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The previous commit compacted the header row of each Grafana panel table but left the old, now-mismatched dash-padding in the separator row untouched. Normalize all separator rows to the same compact style. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…htning metrics reference
- Restore the Prometheus label keys type/name/state/result as literal
English (they were translated to タイプ/名前/状態/結果, but these are
the actual label keys used in the real metric, e.g.
lightning_importer_engine{type="open"}).
- Unify the table/index/region/io idle-worker descriptions from
'`X`の余り' to '未使用の数は`X`', matching this same document's
Grafana panel table wording for the identical value (see
pingcap#23881, which unifies the English source the same way).
- Translate the lightning_import_seconds description, which had been
left as raw, untranslated English.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Revert the table/index/region/io description wording change from the previous commit. The English source fix (pingcap#23881) hasn't merged yet, and this wording will be picked up automatically by the regular EN-to-JA sync once it does, rather than hand-applied here ahead of it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…iption Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lightning_tables and lightning_engines described their state label as 'X の状態', while lightning_chunks (and every intro sentence in this section, including these two metrics' own) already said 'X の ステータス' for the identical English word 'status'. Unify on ステータス, matching the file's own dominant convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
What is changed, added or deleted? (Required)
tidb-lightning/monitor-tidb-lightning.mddocuments the TiDB Lightning Grafana dashboard (Rows 1-7). Its Panel and Series table-column values, and the English row-name portion of each### N行目: <name>heading, had been translated into Japanese. Since these are literal panel/series/row labels from the real Grafana dashboard, translating them makes it impossible for a reader to match the doc against what they actually see in the Grafana UI.Verified against the real TiDB Lightning dashboard JSON (
pingcap/monitoring) and the parallel English doc file. Restored to literal English across all 7 rows, for example:インポート速度→Import speed,Chunk処理期間→Chunk process durationアイドルワーカー→Idle workers,外部リソース→External resourcesSQL処理速度→SQL process rate,合計バイト数→Total bytesクローズ済みエンジン→closed-engine,応募者→apply worker,ストレージサイズ / 3→storage_size / 31行目: スピード→1行目: Speed,7行目: インポート速度→7行目: Import speedAlso translated one Description cell (Row 1, "Chunk process duration") that had been left as raw, untranslated English ("Average time needed to completely encode one single data file") into Japanese.
Description-column prose (the actual explanatory text) was left in Japanese as before — only the literal panel/series/row-name labels were restored to English.
Follow-up scope added to this PR (same file, same "keep literal identifiers literal" principle, found during review):
## Monitoring metricssection's Prometheus label keystype/name/state/resulthad also been translated (タイプ/名前/状態/結果), even though these are the actual label keys used in the real metric output (e.g.lightning_importer_engine{type="open"}). Restored to literal English.statelabel's description wording (テーブルの状態/エンジンの状態→テーブルのステータス/エンジンのステータス) to match this file's own dominant rendering of "status" (used in every metric's intro sentence and inlightning_chunks's ownstatedescription), plus the same word in theestimatedcaveat.lightning_import_secondsdescription, which had been left as raw, untranslated English.Deferred to the upcoming EN→JA sync rather than hand-applied here: unifying the
lightning_idle_workerslabel descriptions ("Xの余り") with this document's own Grafana panel table wording ("未使用の数はX"), since the underlying English-source fix (#23881) hasn't merged yet.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code