Skip to content

test: keep the out-of-memory query under the hard limit in worker mode #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 1 commit into from
Oct 26, 2026
Merged

test: keep the out-of-memory query under the hard limit in worker mode #2778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frankenphp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1724,8 +1724,8 @@ func testOutOfMemory(t *testing.T, opts *testOptions) {
body, _ = testGet("http://example.com/out-of-memory.php", handler, t)
assert.Equal(t, "ok", body)

// $_GET is populated before the script runs; stay under the hard limit (twice memory_limit), past which PHP exits
body, _ = testGet("http://example.com/out-of-memory.php?q="+strings.Repeat("a", 5<<20), handler, t)
// $_GET is populated before the script runs; its copies (4 in worker mode) must cross memory_limit but stay under the hard limit (twice memory_limit), past which PHP exits
body, _ = testGet("http://example.com/out-of-memory.php?q="+strings.Repeat("a", 3<<20), handler, t)
if hardLimit {
assert.Contains(t, body, "Allowed memory size of 8388608 bytes exhausted")
}
Expand Down
Loading