Repository navigation
test: keep the out-of-memory query under the hard limit in worker mode - #2778
Merged
Merged
Conversation
Worker mode holds four copies of the query string while populating the superglobals, so a 5 MiB query crossed the 16 MiB hard limit on the official PHP images and killed the test binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestOutOfMemory_workerkills the test binary in the Docker images (Hard memory limit of 16777216 bytes exhausted), on every variant. It also fails on main, but Docker tests only run on PRs labeled "CI: All jobs", and none ran since #2741 introduced the test.Worker mode holds four copies of the query string while populating the superglobals, so the 5 MiB query crosses the 16 MiB hard limit (twice
memory_limit). The Tests workflow's PHP build stays just under it.3 MiB still crosses
memory_limit, which the test asserts, and stays under the hard limit: 4 MiB still exits, 2 MiB leaves little margin abovememory_limit. Passed 20 times in a row in the Trixie builder image (plus 5 with-race), and with a local PHP 8.5 build.Unblocks #2777.