Expose async persistence in FFI

[spacebear21]

This exposes the async persistence methods in payjoin-ffi and accompanying unit tests in downstream languages.

I wanted to address #1199 so that we wouldn't duplicate all the hardcoded test values so much, but it turned out to be more involved than I anticipated (see my comment on that issue).

Pull Request Checklist

Please confirm the following before requesting review:

• I have disclosed my use of
  AI
  in the body of this PR.
• I have read CONTRIBUTING.md and rebased my branch to produce hygienic commits.

[coveralls]

Pull Request Test Coverage Report for Build 21396851139

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 83.203%

---

Totals
Change from base Build 21370318256:	0.0%
Covered Lines:	10140
Relevant Lines:	12187

---

💛 - Coveralls

[DanGould]

I see the integration test is skipping. In CI: skipped 'bitcoin_ffi helpers are not available in this binding'

and local:

======================================================================
ERROR: test.test_payjoin_integration_test (unittest.loader._FailedTest.test.test_payjoin_integration_test)
----------------------------------------------------------------------
ImportError: Failed to import test module: test.test_payjoin_integration_test
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/unittest/loader.py", line 396, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/unittest/loader.py", line 339, in _get_module_from_name
    __import__(name)
    ~~~~~~~~~~^^^^^^
  File "/Users/dan/f/dev/payjoin/payjoin-ffi/python/test/test_payjoin_integration_test.py", line 11, in <module>
    import payjoin.bitcoin as bitcoinffi
  File "/Users/dan/f/dev/payjoin/payjoin-ffi/python/src/payjoin/bitcoin.py", line 645, in <module>
    _UniffiLib.uniffi_bitcoin_ffi_fn_clone_address.argtypes = (
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/ctypes/__init__.py", line 403, in __getattr__
    func = self.__getitem__(name)
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/ctypes/__init__.py", line 408, in __getitem__
    func = self._FuncPtr((name_or_ordinal, self))
AttributeError: dlsym(0x6d0d1d60, uniffi_bitcoin_ffi_fn_clone_address): symbol not found

Is this entirely intentional? It was added in cc45199 #1191. I don't see discussion of just skipping the integration test there but still passing CI. Is this the intended behavior @chavic?

[DanGould]

One of the python tests no-ops accidentally, that's the only thing I'd really want to fix.

Would be nice to have save/load/close coverage in FFI but for now imo it's ok without.

[chavic]

I see the integration test is skipping. In CI: skipped 'bitcoin_ffi helpers are not available in this binding'

and local:

======================================================================
ERROR: test.test_payjoin_integration_test (unittest.loader._FailedTest.test.test_payjoin_integration_test)
----------------------------------------------------------------------
ImportError: Failed to import test module: test.test_payjoin_integration_test
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/unittest/loader.py", line 396, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/unittest/loader.py", line 339, in _get_module_from_name
    __import__(name)
    ~~~~~~~~~~^^^^^^
  File "/Users/dan/f/dev/payjoin/payjoin-ffi/python/test/test_payjoin_integration_test.py", line 11, in <module>
    import payjoin.bitcoin as bitcoinffi
  File "/Users/dan/f/dev/payjoin/payjoin-ffi/python/src/payjoin/bitcoin.py", line 645, in <module>
    _UniffiLib.uniffi_bitcoin_ffi_fn_clone_address.argtypes = (
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/ctypes/__init__.py", line 403, in __getattr__
    func = self.__getitem__(name)
  File "/opt/homebrew/Cellar/python@3.13/3.13.3/Frameworks/Python.framework/Versions/3.13/lib/python3.13/ctypes/__init__.py", line 408, in __getitem__
    func = self._FuncPtr((name_or_ordinal, self))
AttributeError: dlsym(0x6d0d1d60, uniffi_bitcoin_ffi_fn_clone_address): symbol not found

Is this entirely intentional? It was added in cc45199 #1191. I don't see discussion of just skipping the integration test there but still passing CI. Is this the intended behavior @chavic?

Yeah, that's the expected behavior

[DanGould]

In that case, when do we run & maintain the integration tests?

[spacebear21]

Is this entirely intentional? It was added in cc45199 #1191. I don't see discussion of just skipping the integration test there but still passing CI.

Good catch, I overlooked this on PR review and haven't noticed since.. I agree it needs to be unskipped asap, though this belongs in a separate PR.

[arminsabouri]

Noticed on inconsistency in the dart unit tests. Otherwise Ack .

[arminsabouri]

Is it possible to assert a specific state like we do in the other tests?

[arminsabouri]

Would be nice to have save/load/close coverage in FFI but for now imo it's ok without.

IIRC the persister lifecycle is covered in the integration tests.

[DanGould]

Would be nice to have save/load/close coverage in FFI but for now imo it's ok without.

IIRC the persister lifecycle is covered in the integration tests.

O ya that seems sufficient as long as it's actually running

edit: async & sync tho?

[spacebear21]

edit: async & sync tho?

currently sync only in integration tests. Same as in the core rust tests fwiw. Maybe worth revisiting at some point for fuller coverage.