Don't skip python integration test#1301
Conversation
This removes the skip block and copies the JS/dart integration tests approach for using primitive types instead of bitcoin types
Pull Request Test Coverage Report for Build 21396270742Details
💛 - Coveralls |
| try: | ||
| import payjoin.bitcoin as bitcoinffi | ||
| except ImportError: | ||
| bitcoinffi = None | ||
| raise unittest.SkipTest("bitcoin_ffi helpers are not available in this binding") |
There was a problem hiding this comment.
Whats the rationale for not wanting to use bitcoin-ffi types in these tests? Seems like they are generally help reduce boilerplate e.g in IsScriptOwnedCallback.callback generating an address from spk.
There was a problem hiding this comment.
This is a question for @chavic I think since iirc he authored the change
There was a problem hiding this comment.
Also curious what the original rationale was since this seems intentional per #1287 (comment)
There was a problem hiding this comment.
payjoin-ffi now only accepts primitive data types and no longer re-exports bitcoin-ffi per #738, so import payjoin.bitcoin as bitcoinffi always errors. To reduce boilerplate I think each downstream language could use whatever bitcoin library exists in that language for common operations like script parsing, etc.
4 participants
This removes the skip block and copies the JS/dart integration tests approach for using primitive types instead of bitcoin types.
re: #1287 (comment)
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.