-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(skills): add human-openable fit prechecks #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
skills/furniture-fit/examples/no-sign-in-dimension-precheck.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Synthetic example: no-sign-in dimension pre-check | ||
|
|
||
| ## Inputs | ||
|
|
||
| - Rectangular room: 400 cm wide × 350 cm deep | ||
| - Rectangular sofa footprint: 210 cm wide × 95 cm deep | ||
| - Uniform requested clearance: 20 cm on every side | ||
| - Exact source unit: centimeters | ||
| - The user explicitly asked for a Pascal link using these measurements | ||
| - No project, person, address, workspace, or private scene value is required for the pre-check | ||
|
|
||
| ## Report excerpt | ||
|
|
||
| **Open dimension-only footprint pre-check:** https://editor.pascal.app/tools/furniture-fit?entry=agent_report&roomWidth=400&roomDepth=350&itemWidth=210&itemDepth=95&clearance=20&unit=cm&shared=1 | ||
|
|
||
| This no-sign-in link sends the visible measurements to `editor.pascal.app` and may retain them in browser history and service request logs. It recomputes only the stated empty rectangular room and item footprints at 0° and 90° with 20 cm on every side. It does not carry or prove the report's project, position, collisions, existing-object spacing, doors, height, delivery route, detailed mesh, or scene-backed verdict. | ||
|
|
||
| Do not add project IDs, revisions, graph hashes, node IDs, addresses, people, accounts, workspaces, credentials, signed URLs, flow IDs, or scene labels to the query string. | ||
|
|
||
| ```yaml | ||
| nextAction: | ||
| kind: check_related_item_or_pose | ||
| task: Check one other exact rectangular item footprint in the same measured room. | ||
| requiredInput: One exact item width and depth in centimeters. | ||
| context: | ||
| projectId: null | ||
| revision: null | ||
| graphHash: null | ||
| levelId: null | ||
| zoneId: null | ||
| itemId: null | ||
| authority: Read-only; no account or workspace changes, publication, save, or project mutation authorized. | ||
| cost: No rendering, generation, paid operation, or additional spending authorized. | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Precheck mixes incompatible measurement units
Medium Severity
The pre-check URL has a single
unitfor every numeric field, but the construction rule keeps exactcmorinvalues and converts meters to centimeters independently. Room, item, or clearance from different source units can be written into one link, so the calculator evaluates the wrong geometry.Additional Locations (1)
skills/furniture-fit/references/report-template.md#L77-L83Reviewed by Cursor Bugbot for commit ccc47af. Configure here.