feat(skills): add human-openable fit prechecks - #824
Conversation
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: 4a952868-7d83-4794-bdba-a81b00359403 |
1cea5db to
dfa8323
Compare
dfa8323 to
ccc47af
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ccc47af. Configure here.
| When the user asks for a hosted link, or explicitly confirms that these measurements may be sent to Pascal, an eligible report can include an **Open dimension-only footprint pre-check** link. Eligibility requires exact positive dimensions no greater than `1,000,000` for one rectangular room footprint and one rectangular item footprint. Use the user's original `cm` or `in` values when they are exact; otherwise convert measured meter values to centimeters without rounding away meaningful precision. Use the user's explicit uniform room-boundary clearance when one was supplied. Item-to-item spacing from `check_collisions.minimumClearance` is a different constraint and must not be copied into this link. Use `clearance=0` only for a bare dimensional fit or when the user explicitly requested no added room-boundary clearance. Build only this fixed URL shape, with standard URL encoding: | ||
|
|
||
| ```text | ||
| https://editor.pascal.app/tools/furniture-fit?entry=agent_report&roomWidth=<number>&roomDepth=<number>&itemWidth=<number>&itemDepth=<number>&clearance=<number>&unit=<cm-or-in>&shared=1 |
There was a problem hiding this comment.
Precheck mixes incompatible measurement units
Medium Severity
The pre-check URL has a single unit for every numeric field, but the construction rule keeps exact cm or in values and converts meters to centimeters independently. Room, item, or clearance from different source units can be written into one link, so the calculator evaluates the wrong geometry.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit ccc47af. Configure here.


A furniture-fit agent report can contain exact rectangular dimensions but previously had no safe way to hand those values to a human. This adds a bounded no-sign-in calculator link with
entry=agent_report, while keeping project, scene identifiers, identity, credentials, and scene-backed evidence out of the URL.The skill emits the link only after the user requests or approves sending the measurements to Pascal. It omits links for ambiguous, irregular, over-limit, directional-clearance, or scene-dependent conclusions; distinguishes uniform room-boundary clearance from MCP item spacing; and warns that visible query measurements can remain in browser history and service request logs.
Validation:
bun scripts/validate-skills.tsclaude plugin validate . --strictNote
Medium Risk
Agents may transmit user measurements via external URLs; incorrect eligibility or query construction could mislead users or weaken the stated privacy boundaries, though validation and explicit omit rules mitigate this.
Overview
furniture-fit can now include an Open dimension-only footprint pre-check link—a fixed-shape, no-sign-in calculator URL with
entry=agent_reportand only room/item dimensions, uniform clearance,unit, andshared=1. The skill treats it as separate from the scene-backed verdict, requires user request or consent before emitting it, and marks it unavailable when inputs are irregular, asymmetric, over-limit, ambiguous, or when an empty-room link would contradict scene-specific evidence (collisions, pose, doors, etc.).Documentation and examples are updated (
report-template.md, newno-sign-in-dimension-precheck.md, insufficient-evidence excerpt), plus five eval cases covering happy path and omit scenarios.validate-skills.tsnow enforces the canonical URL shape, query keys, bounds, and required privacy/copy boundaries in SKILL.md. Plugin manifests and furniture-fit metadata bump to 0.1.8 / 0.1.4.Reviewed by Cursor Bugbot for commit ccc47af. Bugbot is set up for automated code reviews on this repo. Configure here.