Repository navigation
[Docs] Contributor setup: Node 22.23.4+ to match engines floor - #1143
Merged
Merged
Conversation
Co-authored-by: Aymeric Rabot <Aymericr@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the contributor prerequisites from
Node.js 22.18+toNode.js 22.23.4+so they match the rootpackage.jsonengines.nodefloor (>=22.23.4), which was raised in #1142.SETUP.mdline 5CONTRIBUTING.mdline 9No other docs stated the 22.18 development floor (searched the whole repo, including
wiki/,.github/and.agents/). This is a docs-only change: no code,package.json, lockfiles or CI are touched.Published CLI/MCP Node mentions are unchanged on purpose. The "Node.js 22.13 or newer" lines in
README.md,SETUP.md(~line 83),packages/cli/README.md,packages/mcp/README.mdandskills/**describe the npm-published@pascal-app/cli@1.0.6, which still requires>=22.13.0. They stay at 22.13 until a CLI release after 1.0.6.How to test
git show origin/main:package.json | grep -A1 enginesshows"node": ">=22.23.4".SETUP.mdandCONTRIBUTING.mdprerequisites now sayNode.js 22.23.4+.rg '22\.18'returns no matches outside lockfiles.Screenshots / screen recording
N/A — non-visual change
Checklist
bun devbun checkto verify)mainbranchNote
Low Risk
Documentation-only change to prerequisite text; no code, tooling, or release artifacts are modified.
Reviewed by Cursor Bugbot for commit d54f050. Bugbot is set up for automated code reviews on this repo. Configure here.