Repository navigation
[Docs] Contributor setup: Node per-major engines range - #1145
Merged
Merged
Conversation
Co-authored-by: Aymeric Rabot <Aymericr@users.noreply.github.com>
Aymericr
marked this pull request as ready for review
October 25, 2026 14:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#1144 changed
engines.nodein the rootpackage.jsonandpackages/cli/package.jsonto^22.23.4 || ^24.22.1 || >=26.12.1. The contributor prerequisites inSETUP.mdandCONTRIBUTING.md(last updated by #1143) still said "Node.js 22.23.4+", which wrongly accepts Node 23, 24 below 24.22.1, and 25/26 below 26.12.1.Both prerequisite lines now read: Node.js 22.23.4 or later on 22.x, 24.22.1 or later on 24.x, or 26.12.1 or later (Node 23 and 25 are not supported).
Intentionally left unchanged: the "Node.js 22.13 or newer" lines in
README.md, the CLI-managed editor section ofSETUP.md,packages/cli/README.md,packages/mcp/README.mdand the skills docs. They describe running the published@pascal-app/clivianpx, and the released 1.0.6 on npm declaresengines.node: >=22.13.0. They should be updated with the next CLI release that ships the new range.How to test
engines.nodeinpackage.jsonandpackages/cli/package.jsonwith the Prerequisites sections ofSETUP.mdandCONTRIBUTING.md; they should match.rg -n "22\.23\.4" --glob '*.md'shows only the two updated lines.Screenshots / screen recording
N/A — non-visual change
Checklist
bun devbun checkto verify)mainbranchNote
Low Risk
Documentation-only change to contributor setup prerequisites; no runtime or build behavior changes.
Reviewed by Cursor Bugbot for commit c89b8e8. Bugbot is set up for automated code reviews on this repo. Configure here.