Repository navigation
[FSSDK-13263] chore!: remove CocoaPods support, require iOS 15 and Flutter 3.44 - #119
Merged
Merged
Conversation
muzahidul-opti
marked this pull request as draft
October 13, 2026 16:19
… to 15.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OptimizelySwiftSDK 6.0.0 dropped CocoaPods distribution, so the plugin's iOS integration moves to Swift Package Manager only. The podspec, the CocoaPods-only Objective-C shim, and the podspec/SPM version-parity CI check are removed. The example app is migrated off CocoaPods. BREAKING CHANGE: iOS apps must target iOS 15.0 or later, use Flutter 3.44 or later, and integrate the plugin via Swift Package Manager. CocoaPods is no longer supported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
muzahidul-opti
force-pushed
the
feature/remove-cocoapods-ios15
branch
from
October 13, 2026 17:00
244b6a9 to
1d3124a
Compare
muzahidul-opti
marked this pull request as ready for review
October 13, 2026 17:00
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pvcraven
previously approved these changes
Oct 14, 2026
pvcraven
left a comment
There was a problem hiding this comment.
This looks good to merge. As noted, really important to only get released as 4.0.0 or else we'll break stuff.
Claude notes:
Needs changing, by priority:
- P1: Release only as 4.0.0. Dropping CocoaPods and raising the minimums to iOS 15 and Flutter 3.44 breaks some customers. Flutter 3.44+ users who turned Swift Package Manager (SPM) off would get this on a normal pub upgrade if it shipped as 3.x. Once this merges, master can't produce a 3.x release.
- P1: Check the optimizely-flutter-testapp repo before merging. The iOS integration job builds that repo's master. If it still uses a Podfile or targets iOS below 15, the job either fails or passes without testing SPM. A green check alone doesn't prove the iOS SPM path ran.
- P2: The iOS CI job never builds iOS. build_test_ios only runs the Dart unit tests. With the version-parity check removed, nothing in this repo compiles either Package.swift. I'd add flutter build ios --no-codesign --simulator on the example app.
- P2: The example app can't install its dependencies on Flutter 3.44. example/pubspec.yaml still caps Dart below 3.0, and Flutter 3.44 ships Dart 3. That cap was already there, but this PR makes Flutter 3.44 the minimum, so no supported Flutter can run the example now.
- P3: The macOS move to SPM isn't verified. Nothing in CI or the spec checks it, and the spec doesn't mention it. The macOS plugin is an experimental stub, so impact is low.
- P3: Some docs are out of date:
- .github/copilot-instructions.md lists native SDK versions 5.2.1 / 5.1.1; the pinned versions are 5.5.0 / 5.4.0.
- The README says Android compile SDK 32; the project uses 35.
- The README migration steps should cover apps that explicitly turned SPM off, since those are the ones that break.
- P4: Nits. The Dart lower bound of 2.16.2 is misleading now that Flutter 3.44 is required. The CHANGELOG entry needs migration steps when 4.0.0 is cut.
…pt-out migration step Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@pvcraven Thanks for the review. I went through each point:
🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptimizelySwiftSDK 6.0.0 dropped CocoaPods, so the plugin's iOS integration becomes SPM-only. Swift SDK stays at 5.5.0 (from 3.8.0, #120) here; the 6.0.0 bump is a separate PR. Rebased on
masterafter the 3.8.0 release. Ships in 4.0.0 only, so don't release this on its own.iOS plugin registration is unchanged (
pluginClass: SwiftOptimizelyFlutterSdkPlugin). No Dart API changes.Evidence
After (local):
Merge Danger
Door: one-way once released (4.0.0 drops CocoaPods and iOS <15 for consumers). Until release it's a two-way door: revert the commit.
Blast Radius:
integration_ios_testsbuilds testappmaster, so merge optimizely/optimizely-flutter-testapp#46 first.example/from a checkout folder namedoptimizely-flutter-sdk(hyphens) fails SPM identity resolution, andmasterfails the same way. CI doesn't build the example.getPlatformVersion.🤖 Generated with Claude Code