Skip to content

Remove not used libsonic download #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rasapala merged 1 commit into from
Sep 17, 2026
Merged

Remove not used libsonic download #4577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion third_party/espeak_ng/out_of_source_phsource.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

Replace configure-time file(COPY) of phsource with a symbolic link.
Replace configure-time file(COPY) of phsource with a symbolic link and avoid
fetching disabled Sonic support.

Upstream cmake/data.cmake does:

Expand All @@ -25,8 +26,17 @@ symlink eliminates the entire copy step and guarantees the build always
sees the exact source phsource tree. phsource is read-only during the
build, so a symlink is safe.

OVMS builds with USE_LIBSONIC=OFF, so CMake must not fetch Sonic when it is not
installed on the builder.

This patch is OVMS-local; see third_party/espeak_ng/espeak_ng.bzl.

--- a/cmake/deps.cmake
+++ b/cmake/deps.cmake
@@ -18 +18 @@
-else()
+elseif(USE_LIBSONIC)

--- a/cmake/data.cmake
+++ b/cmake/data.cmake
@@ -58,7 +58,8 @@
Expand Down