Remove not used libsonic download - #4577
Merged
Merged
Conversation
rasapala
requested review from
atobiszei and
mzegla
and
a lite review from Copilot
September 17, 2026 09:16
mzegla
approved these changes
Sep 17, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Updates the eSpeak-ng patch to avoid downloading unused libsonic support when USE_LIBSONIC=OFF.
Changes:
- Gates Sonic dependency fetching on
USE_LIBSONIC. - Clarifies patch documentation.
File summaries
| File | Summary |
|---|---|
third_party/espeak_ng/out_of_source_phsource.patch |
Updates eSpeak-ng dependency configuration. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
przepeck
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA CVS-195010
🧪 Checklist
``