Repository navigation
chore(ci): bump org.bouncycastle:bc-fips from 2.1.2 to 2.1.3 - #407
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
dependabot
Bot
force-pushed
the
dependabot/maven/org.bouncycastle-bc-fips-2.1.3
branch
from
September 25, 2026 18:23
14d2c94 to
8d1dcd7
Compare
Contributor
mkleene
approved these changes
Sep 28, 2026
dependabot
Bot
force-pushed
the
dependabot/maven/org.bouncycastle-bc-fips-2.1.3
branch
from
October 1, 2026 17:06
8d1dcd7 to
085bf56
Compare
Contributor
dependabot
Bot
force-pushed
the
dependabot/maven/org.bouncycastle-bc-fips-2.1.3
branch
from
October 15, 2026 18:35
085bf56 to
c0be26b
Compare
Contributor
This was referenced Oct 20, 2026
dmihalcik-virtru
added a commit
that referenced
this pull request
Oct 21, 2026
## Summary - **checks.yaml / mavenverify:** pass `-Dsonar.skip=true` when `SONAR_TOKEN` is empty. Pushes to `main` and same-repo PRs still run the Sonar analysis. - **codeql.yaml:** pass `github_token` to `buf-setup-action`, as `checks.yaml` already does. ## Rationale Dependabot and fork PRs can't read Actions secrets. On #408, #407 and #387, `mavenverify` gets through the build and all tests, then fails in the Sonar goal: > [ERROR] Not authorized. Please check the 'sonar.token' property or the 'SONAR_TOKEN' environment variable ... `sonar-maven-plugin` checks `sonar.skip` before it starts the scanner ([source](https://github.com/SonarSource/sonar-scanner-maven/blob/master/sonar-maven-plugin/src/main/java/org/sonarsource/scanner/maven/SonarQubeMojo.java)), so the job now passes or fails on the build and tests alone. I put the change in the workflow instead of `pom.xml` because it depends on the CI environment. CodeQL on #407 failed with `API rate limit exceeded` inside the buf setup step. Without a token, that step calls the GitHub API unauthenticated and shares the runner IP's rate limit. ## Test plan - [x] YAML parses; checked the skip logic for empty and non-empty `SONAR_TOKEN` - [ ] This PR's own `mavenverify` still runs Sonar (token available) - [ ] After merge, the recreated Dependabot PRs show `sonar.skip = true: Skipping analysis` and `mavenverify` passes Companion PR: #425 (Dependabot PR titles). Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
dmihalcik-virtru
added a commit
that referenced
this pull request
Oct 21, 2026
## Summary Adds `.github/dependabot.yml` so Dependabot PR titles pass the conventional commit check. - Runtime dependency bumps → `fix(main): bump ...` (release-please cuts a patch release) - Development/test-scoped bumps → `chore(ci): bump ...` - `open-pull-requests-limit: 0` keeps version updates off. Dependabot keeps opening security-update PRs only, as it does today, and those now use the prefixes too. ## Rationale All three open Dependabot PRs (#408, #407, #387) fail **Validate PR title**: > Unknown scope "deps" found in pull request title "chore(deps): bump org.bouncycastle:bcprov-jdk18on from 1.84 to 1.85". Scope must match one of: ci, cmdline, docs, main, sdk, tests, examples, release/v0\.\d+. Dependabot adds the `:` after a prefix ending in `)` ([docs](https://docs.github.com/code-security/dependabot/working-with-dependabot/dependabot-options-reference#commit-message--)). ## Caveat Dependabot decides what counts as a development dependency. It labeled `bc-fips` as `deps-dev` (it's `test` scope in `sdk/pom.xml`) even though `sdk-fips-bc` depends on it at compile scope. So `bc-fips` bumps will be titled `chore(ci)`, and release-please won't cut a release for them. Retitle those PRs to `fix(main)` before merging. ## Test plan - [x] YAML parses - [ ] After merge, comment `@dependabot recreate` on #408, #407, #387 and check the new titles pass the PR-title check Companion PR: skip the Sonar scan when `SONAR_TOKEN` is unavailable. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit - **Chores** - Added automated weekly dependency update checks across Maven-based project areas. - Security updates remain enabled, while routine non-security version updates are not opened automatically. - Automated dependency changes now follow consistent commit message conventions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
Member
|
@dependabot recreate |
Bumps org.bouncycastle:bc-fips from 2.1.2 to 2.1.3. --- updated-dependencies: - dependency-name: org.bouncycastle:bc-fips dependency-version: 2.1.3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/maven/org.bouncycastle-bc-fips-2.1.3
branch
from
October 21, 2026 00:46
c0be26b to
52db219
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps org.bouncycastle:bc-fips from 2.1.2 to 2.1.3.