Repository navigation
chore(ci): skip Sonar analysis when SONAR_TOKEN is unavailable - #426
Merged
Merged
Conversation
Dependabot and fork PRs can't read the SONAR_TOKEN secret, so the Sonar goal in mavenverify fails with "Not authorized" after the tests have passed, and the PR shows red. Pass -Dsonar.skip when the token is empty so the job reflects the build and test result. Pushes to main and same-repo PRs still run the analysis. Also pass GITHUB_TOKEN to buf-setup-action in the CodeQL workflow, as checks.yaml already does; without it the action calls the GitHub API unauthenticated and can fail on the shared runner rate limit. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
elizabethhealy
approved these changes
Oct 20, 2026
pflynn-virtru
approved these changes
Oct 20, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Dsonar.skip=truewhenSONAR_TOKENis empty. Pushes tomainand same-repo PRs still run the Sonar analysis.github_tokentobuf-setup-action, aschecks.yamlalready does.Rationale
Dependabot and fork PRs can't read Actions secrets. On #408, #407 and #387,
mavenverifygets through the build and all tests, then fails in the Sonar goal:sonar-maven-plugincheckssonar.skipbefore it starts the scanner (source), so the job now passes or fails on the build and tests alone. I put the change in the workflow instead ofpom.xmlbecause it depends on the CI environment.CodeQL on #407 failed with
API rate limit exceededinside the buf setup step. Without a token, that step calls the GitHub API unauthenticated and shares the runner IP's rate limit.Test plan
SONAR_TOKENmavenverifystill runs Sonar (token available)sonar.skip = true: Skipping analysisandmavenverifypassesCompanion PR: #425 (Dependabot PR titles).