Skip to content

api: register aws-rhdh-disconnected cluster profile#5205

Open
zdrapela wants to merge 1 commit into
openshift:mainfrom
zdrapela:add-aws-rhdh-disconnected-profile
Open

api: register aws-rhdh-disconnected cluster profile#5205
zdrapela wants to merge 1 commit into
openshift:mainfrom
zdrapela:add-aws-rhdh-disconnected-profile

Conversation

@zdrapela
Copy link
Copy Markdown

@zdrapela zdrapela commented May 27, 2026

Add a dedicated AWS cluster profile for RHDH disconnected CI jobs.

This enables the RHDH team to use their own AWS account for disconnected (air-gapped) E2E tests.

Changes:

  • New constant: ClusterProfileAWSRHDHDisconnected ("aws-rhdh-disconnected")
  • Cluster type: aws (reuses existing AWS type)
  • Lease type: aws-rhdh-disconnected-quota-slice
  • Region: us-east-2

Companion PR for openshift/release will add the Boskos quota slice configuration, secret bootstrap entry, and update RHDH CI jobs to use this profile.

Jira: https://redhat.atlassian.net/browse/RHIDP-13968

Docs

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot requested review from droslean and smg247 May 27, 2026 09:41
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

📝 Walkthrough

Walkthrough

Adds a new ClusterProfileAWSRHDHDisconnected constant and registers it in the cluster profile catalog, the ClusterType mapping (AWS group), and LeaseType mapping (returns aws-rhdh-disconnected-quota-slice).

Changes

AWS RHDH Disconnected cluster profile

Layer / File(s) Summary
Cluster profile constant and wiring
pkg/api/clusterprofile.go
ClusterProfileAWSRHDHDisconnected constant is declared, added to the ClusterProfiles() catalog, included in the AWS/CloudAWS case group in ClusterType(), and configured to return the aws-rhdh-disconnected-quota-slice lease type in LeaseType().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 14
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: registering a new AWS cluster profile constant for RHDH disconnected CI jobs.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed All code changes are simple constant and list/switch statement additions with no error handling code. No ignored errors, panic calls, or nil dereferences found.
Test Coverage For New Features ✅ Passed New cluster profile constant is added to ClusterProfiles() list and automatically tested by existing TestClusterProfilesConfig, which validates ClusterType() and LeaseType() for all profiles.
Stable And Deterministic Test Names ✅ Passed PR modifies only pkg/api/clusterprofile.go (adding a constant). No Ginkgo test files modified; no Ginkgo test code present. Check not applicable to this PR.
Test Structure And Quality ✅ Passed No Ginkgo test code present in PR. Changes only add cluster profile constant and wire it through catalog—check not applicable.
Microshift Test Compatibility ✅ Passed PR adds a cluster profile constant and wiring to pkg/api/clusterprofile.go. No Ginkgo e2e tests are added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds only a cluster profile constant and mappings. No Ginkgo e2e tests are present, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed This PR adds only a cluster profile constant and configuration mappings in pkg/api/clusterprofile.go. No deployment manifests, operator code, controllers, or scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed The PR adds a cluster profile constant to a configuration package with no stdout-writing code, init functions, or process-level setup that could corrupt OTE binary output.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only a cluster profile constant definition and configuration wiring to pkg/api/clusterprofile.go. No Ginkgo e2e tests are added, so the IPv6/disconnected compatibility check does not apply.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zdrapela
Once this PR has been reviewed and has the lgtm label, please assign psalajova for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdrapela zdrapela changed the title Add aws-rhdh-disconnected cluster profile api: register aws-rhdh-disconnected cluster profile May 27, 2026
zdrapela added a commit to zdrapela/release that referenced this pull request May 27, 2026
Switch disconnected CI jobs from openshift-org-aws to the dedicated
aws-rhdh-disconnected cluster profile. RHDH is a layered product and
must not use the shared core OpenShift AWS budget (openshift-org-aws).

The aws-rhdh-disconnected profile is being added in:
- openshift/ci-tools#5205 (profile constant)
- openshift#79749 (Boskos lease + secret bootstrap)

Both PRs must merge before this PR can pass CI validation.

Assisted-by: OpenCode
Add a dedicated AWS cluster profile for RHDH disconnected CI jobs.
This enables the RHDH team to use their own AWS account for
disconnected (air-gapped) installation tests, allowing direct
resource cleanup verification.

- New constant: ClusterProfileAWSRHDHDisconnected
- Cluster type: aws (reuses existing AWS type)
- Lease type: aws-rhdh-disconnected-quota-slice
- Region: us-east-2

Assisted-by: OpenCode
@zdrapela zdrapela force-pushed the add-aws-rhdh-disconnected-profile branch from 58ddb7b to 67d8146 Compare May 27, 2026 11:02
@zdrapela
Copy link
Copy Markdown
Author

/retest

@zdrapela
Copy link
Copy Markdown
Author

/test lint

openshift-merge-bot Bot pushed a commit to openshift/release that referenced this pull request May 28, 2026
Add infrastructure configuration for the new aws-rhdh-disconnected
cluster profile, which gives the RHDH team a dedicated AWS account
for disconnected (air-gapped) CI tests.

Changes:
- Boskos: add aws-rhdh-disconnected-quota-slice with 5 slots in us-east-2
- Secret bootstrap: add cluster-secrets-aws-rhdh-disconnected to the
  shared AWS pull-secret/SSH-key stanza

The cluster profile constant is being added in openshift/ci-tools#5205.
RHDH disconnected CI jobs will be updated to use this profile in a
separate PR.

Assisted-by: OpenCode
@zdrapela
Copy link
Copy Markdown
Author

/test ci/prow/e2e

@zdrapela
Copy link
Copy Markdown
Author

/ok-to-test

@zdrapela
Copy link
Copy Markdown
Author

/test e2e

@openshift-ci openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 29, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

@zdrapela: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 67d8146 link true /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant