Skip to content

Add aws-rhdh-disconnected Boskos lease and secret bootstrap#79749

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
zdrapela:add-aws-rhdh-disconnected-profile
May 28, 2026
Merged

Add aws-rhdh-disconnected Boskos lease and secret bootstrap#79749
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
zdrapela:add-aws-rhdh-disconnected-profile

Conversation

@zdrapela
Copy link
Copy Markdown
Contributor

@zdrapela zdrapela commented May 27, 2026

Add infrastructure configuration for the new aws-rhdh-disconnected cluster profile, which gives the RHDH team a dedicated AWS account for disconnected (air-gapped) CI tests.

Changes:

  • Boskos: add aws-rhdh-disconnected-quota-slice with 5 slots in us-east-2
  • Secret bootstrap: add cluster-secrets-aws-rhdh-disconnected to the shared AWS pull-secret/SSH-key stanza

Dependencies:

Jira: https://redhat.atlassian.net/browse/RHIDP-13968

Docs

Add infrastructure configuration for the new aws-rhdh-disconnected
cluster profile, which gives the RHDH team a dedicated AWS account
for disconnected (air-gapped) CI tests.

Changes:
- Boskos: add aws-rhdh-disconnected-quota-slice with 5 slots in us-east-2
- Secret bootstrap: add cluster-secrets-aws-rhdh-disconnected to the
  shared AWS pull-secret/SSH-key stanza

The cluster profile constant is being added in openshift/ci-tools#5205.
RHDH disconnected CI jobs will be updated to use this profile in a
separate PR.

Assisted-by: OpenCode
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Walkthrough

This PR configures infrastructure for a new disconnected RHDH environment on AWS by defining Boskos quota slices for us-east-2 and adding corresponding CI secret bootstrap entries scoped to non-app CI cluster groups.

Changes

AWS RHDH Disconnected Infrastructure

Layer / File(s) Summary
Boskos quota slice configuration
core-services/prow/02_config/generate-boskos.py, core-services/prow/02_config/_boskos.yaml
Adds aws-rhdh-disconnected-quota-slice to the generator CONFIG with us-east-2 quota count of 5, which generates the corresponding Boskos resource entry with five slice names in free state.
CI secret bootstrap for disconnected RHDH
core-services/ci-secret-bootstrap/_config.yaml
Adds cluster-secrets-aws-rhdh-disconnected secret target mapping scoped to non_app_ci cluster groups in the ci namespace.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding Boskos lease and secret bootstrap configuration for the aws-rhdh-disconnected infrastructure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only infrastructure configuration files (YAML and Python scripts). No Ginkgo test files or code were modified, so the test name stability check is not applicable.
Test Structure And Quality ✅ Passed PR contains only infrastructure configuration (YAML and Python script), no Ginkgo test code. Check for Ginkgo test quality is not applicable.
Microshift Test Compatibility ✅ Passed PR adds no Ginkgo e2e tests—only infrastructure YAML config and Python scripts. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds infrastructure configuration (YAML/Python) only, with no Ginkgo e2e tests. SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR contains only CI resource configuration (Boskos quotas, secret bootstrap). No deployment manifests, operators, or scheduling constraints added.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML config files and a Python script generator—no Go test binaries or process-level code that could violate OTE stdout contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are infrastructure configuration only: YAML config files and a Python script for generating YAML. This check is not applicable.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from danilo-gemoli and droslean May 27, 2026 09:43
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 27, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@zdrapela: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

@zdrapela: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

zdrapela added a commit to zdrapela/release that referenced this pull request May 27, 2026
Switch disconnected CI jobs from openshift-org-aws to the dedicated
aws-rhdh-disconnected cluster profile. RHDH is a layered product and
must not use the shared core OpenShift AWS budget (openshift-org-aws).

The aws-rhdh-disconnected profile is being added in:
- openshift/ci-tools#5205 (profile constant)
- openshift#79749 (Boskos lease + secret bootstrap)

Both PRs must merge before this PR can pass CI validation.

Assisted-by: OpenCode
@danilo-gemoli
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, zdrapela

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 20717a4 into openshift:main May 28, 2026
15 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

@zdrapela: Updated the following 3 configmaps:

  • ci-secret-bootstrap configmap in namespace ci at cluster app.ci using the following files:
    • key _config.yaml using file core-services/ci-secret-bootstrap/_config.yaml
  • ci-secret-bootstrap configmap in namespace ci at cluster core-ci using the following files:
    • key _config.yaml using file core-services/ci-secret-bootstrap/_config.yaml
  • resources configmap in namespace ci at cluster app.ci using the following files:
    • key boskos.yaml using file core-services/prow/02_config/_boskos.yaml
Details

In response to this:

Add infrastructure configuration for the new aws-rhdh-disconnected cluster profile, which gives the RHDH team a dedicated AWS account for disconnected (air-gapped) CI tests.

Changes:

  • Boskos: add aws-rhdh-disconnected-quota-slice with 5 slots in us-east-2
  • Secret bootstrap: add cluster-secrets-aws-rhdh-disconnected to the shared AWS pull-secret/SSH-key stanza

Dependencies:

Jira: https://redhat.atlassian.net/browse/RHIDP-13968

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants