Skip to content

Allow groups to be passed as sequence of floats in convert_to_multigroup #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulromano merged 5 commits into from
Mar 12, 2026
Merged

Allow groups to be passed as sequence of floats in convert_to_multigroup #3873

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d7a024
Update convert_to_multigroup to accept numbers for groups parameter i…
chris-ashe Mar 12, 2026
d08f530
Update groups parameter handling to accept lists or tuples in convert…
chris-ashe Mar 12, 2026
9cb2462
Apply suggestions from code review
chris-ashe Mar 12, 2026
f371e1e
Update openmc/model/model.py
chris-ashe Mar 12, 2026
136c12b
Simplify instance check, update docstring
paulromano Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions openmc/model/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2520,7 +2520,7 @@ def _generate_material_wise_mgxs(
def convert_to_multigroup(
self,
method: str = "material_wise",
groups: str = "CASMO-2",
groups: str | Sequence[float] | openmc.mgxs.EnergyGroups = "CASMO-2",
nparticles: int = 2000,
overwrite_mgxs_library: bool = False,
mgxs_path: PathLike = "mgxs.h5",
Expand All @@ -2538,9 +2538,13 @@ def convert_to_multigroup(
----------
method : {"material_wise", "stochastic_slab", "infinite_medium"}, optional
Method to generate the MGXS.
groups : openmc.mgxs.EnergyGroups or str, optional
Energy group structure for the MGXS or the name of the group
structure (based on keys from openmc.mgxs.GROUP_STRUCTURES).
groups : openmc.mgxs.EnergyGroups, str, or sequence of float, optional
Energy group structure for the MGXS. Can be an
:class:`openmc.mgxs.EnergyGroups` object, a string name of a
predefined group structure from :data:`openmc.mgxs.GROUP_STRUCTURES`
(e.g., ``"CASMO-2"``), or a sequence of floats specifying energy
bin boundaries in eV (e.g., ``[0.0, 1e6]`` for a single group).
Defaults to ``"CASMO-2"``.
nparticles : int, optional
Number of particles to simulate per batch when generating MGXS.
overwrite_mgxs_library : bool, optional
Expand Down Expand Up @@ -2577,7 +2581,7 @@ def convert_to_multigroup(
Valid entries for temperature_settings are the same as the valid
entries in openmc.Settings.temperature_settings.
"""
if isinstance(groups, str):
if not isinstance(groups, openmc.mgxs.EnergyGroups):
groups = openmc.mgxs.EnergyGroups(groups)

# Do all work (including MGXS generation) in a temporary directory
Expand Down
Loading