Skip to content

Allow groups to be passed as sequence of floats in convert_to_multigroup#3873

Merged
paulromano merged 5 commits intoopenmc-dev:developfrom
chris-ashe:3524_convert_to_multigroupto_accept_numbers_for_groups
Mar 12, 2026
Merged

Allow groups to be passed as sequence of floats in convert_to_multigroup#3873
paulromano merged 5 commits intoopenmc-dev:developfrom
chris-ashe:3524_convert_to_multigroupto_accept_numbers_for_groups

Conversation

@chris-ashe
Copy link
Contributor

@chris-ashe chris-ashe commented Mar 12, 2026 •
edited by paulromano
Loading

Description

Please include a summary of the change and which issue is fixed if applicable. Please also include relevant motivation and context.

Fixes #3524

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

shimwell
shimwell reviewed Mar 12, 2026
View reviewed changes
shimwell
shimwell reviewed Mar 12, 2026
View reviewed changes
shimwell
shimwell reviewed Mar 12, 2026
View reviewed changes
@chris-ashe @shimwell
Apply suggestions from code review
9cb2462 
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
shimwell
shimwell reviewed Mar 12, 2026
View reviewed changes
@chris-ashe chris-ashe marked this pull request as ready for review March 12, 2026 10:47
chris-ashe and others added 2 commits March 12, 2026 10:48
@chris-ashe @shimwell
Update openmc/model/model.py
f371e1e 
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
@paulromano
Simplify instance check, update docstring
136c12b
@paulromano paulromano changed the title 3524 convert to multigroup to accept numbers for groups Allow groups to be passed as sequence of floats in Model.convert_to_multigroup Mar 12, 2026
@paulromano paulromano changed the title Allow groups to be passed as sequence of floats in Model.convert_to_multigroup Allow groups to be passed as sequence of floats in convert_to_multigroup Mar 12, 2026
paulromano
paulromano approved these changes Mar 12, 2026
View reviewed changes
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulromano paulromano enabled auto-merge (squash) March 12, 2026 18:56
@paulromano paulromano merged commit c44d2f0 into openmc-dev:develop Mar 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shimwell shimwell shimwell left review comments

@paulromano paulromano paulromano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

convert_to_multigroup to accept numbers for groups

3 participants

@chris-ashe @paulromano @shimwell