Skip to content

ci,fix: stop drift-to-issue skipped emails; replace log.Fatalf with panic in config init #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fullstackjam merged 2 commits into from
Jun 1, 2026
Merged

ci,fix: stop drift-to-issue skipped emails; replace log.Fatalf with panic in config init #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2938371
fix: replace log.Fatalf with panic in config init() functions
fullstackjam Jun 1, 2026
84871c9
ci: stop skipped-job emails from drift-to-issue workflow
fullstackjam Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/drift-to-issue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ permissions:

jobs:
open-or-update-issue:
if: github.event.workflow_run.conclusion == 'failure'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Find failed jobs and (re)open issues
if: github.event.workflow_run.conclusion == 'failure'
env:
GH_TOKEN: ${{ github.token }}
RUN_ID: ${{ github.event.workflow_run.id }}
Expand Down
5 changes: 2 additions & 3 deletions internal/config/packages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package config

import (
"embed"
"log"
"sync"

"gopkg.in/yaml.v3"
Expand Down Expand Up @@ -36,12 +35,12 @@ var (
func init() {
data, err := packagesYAML.ReadFile("data/packages.yaml")
if err != nil {
log.Fatalf("Failed to read packages.yaml: %v", err)
panic("corrupt binary: embedded packages.yaml unreadable: " + err.Error())
}

var pd packagesData
if err := yaml.Unmarshal(data, &pd); err != nil {
log.Fatalf("Failed to parse packages.yaml: %v", err)
panic("corrupt binary: embedded packages.yaml unparseable: " + err.Error())
}

Categories = pd.Categories
Expand Down
5 changes: 2 additions & 3 deletions internal/config/presets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package config

import (
"embed"
"log"

"gopkg.in/yaml.v3"
)
Expand All @@ -16,12 +15,12 @@ var presetOrder = []string{"minimal", "developer", "full"}
func init() {
data, err := presetsYAML.ReadFile("data/presets.yaml")
if err != nil {
log.Fatalf("Failed to read presets.yaml: %v", err)
panic("corrupt binary: embedded presets.yaml unreadable: " + err.Error())
}

var pd presetsData
if err := yaml.Unmarshal(data, &pd); err != nil {
log.Fatalf("Failed to parse presets.yaml: %v", err)
panic("corrupt binary: embedded presets.yaml unparseable: " + err.Error())
}

Presets = pd.Presets
Expand Down
Loading