ci,fix: stop drift-to-issue skipped emails; replace log.Fatalf with panic in config init#119
Merged
Merged
Conversation
log.Fatal calls os.Exit(1) which skips all deferred cleanup. The embedded YAML cannot fail at runtime (compiled-in), so these are effectively startup assertions — panic is the right primitive here. Also removes the unused log import from both files.
When Harness succeeds, the drift-to-issue job was skipped entirely (job-level if: condition). GitHub treats a workflow where all jobs are skipped as conclusion=skipped, not success, which triggers failure notification emails even though nothing is wrong. Move the condition to the step level so the job always runs and concludes as success — the actual issue-filing step only fires when Harness truly fails.
fullstackjam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if: conclusion == 'failure'from the job level to the step level indrift-to-issue.ymlso the workflow reportssuccess(notskipped) when no failure is detected — GitHub only sends emails onfailure, so the skipped-job emails stoplog.Fatalfwithpanicininternal/config/packages.goandinternal/config/presets.goinit()functions:log.Fatalcallsos.Exit(1)which skips all deferred cleanup;panicis the correct primitive for a startup assertion on compiled-in static data that should never failTest plan
unit (L1)passes on CIlintpasses on CIgo build ./...+go vet ./...clean locally