Skip to content

Use plural plugin install extension in core#28819

Open
zswang-oai wants to merge 1 commit into
nm-codex/plugin-installs-corefrom
nm-codex/plugin-installs-core-cutover
Open

Use plural plugin install extension in core#28819
zswang-oai wants to merge 1 commit into
nm-codex/plugin-installs-corefrom
nm-codex/plugin-installs-core-cutover

Conversation

@zswang-oai

@zswang-oai zswang-oai commented Jun 18, 2026

Copy link
Copy Markdown

Why

With the extension and core backend in place, core can expose the plural tool while preserving Noah's original install picker behavior.

What changed

  • register request_plugin_installs through the extension executor
  • use the single-entry mode for TUI and the plural mode for desktop clients
  • route recommendation context and list-tool guidance to the plural name
  • read nested picker metadata for elicitation telemetry
  • stop compiling the old core handler
  • update integration coverage for the plural tool

The emitted picker metadata remains the original nested entries / categories contract, including per-entry Install buttons and the Skip / Continue footer.

Stack

This is PR 6 of 7.

@zswang-oai zswang-oai marked this pull request as ready for review June 18, 2026 05:03
@zswang-oai zswang-oai requested a review from a team as a code owner June 18, 2026 05:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1a8f0f3c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1283 to +1284
extension_tool_executors.push(
codex_plugin_installs_extension::request_plugin_installs_tool(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reserve the core plugin installer before extension tools

When a session has an extension contributor that registers a plain request_plugin_installs tool, this appends the core installer after contributed extension tools. append_extension_tool_executors keeps the first executor for a tool name and skips later duplicates, so in that scenario the model-visible install suggestion tool is backed by the external extension instead of CoreRequestPluginInstallsBackend, and plugin recommendations/list results can no longer trigger the expected Codex install elicitation.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant