Use plural plugin install extension in core#28819
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1a8f0f3c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| extension_tool_executors.push( | ||
| codex_plugin_installs_extension::request_plugin_installs_tool( |
There was a problem hiding this comment.
Reserve the core plugin installer before extension tools
When a session has an extension contributor that registers a plain request_plugin_installs tool, this appends the core installer after contributed extension tools. append_extension_tool_executors keeps the first executor for a tool name and skips later duplicates, so in that scenario the model-visible install suggestion tool is backed by the external extension instead of CoreRequestPluginInstallsBackend, and plugin recommendations/list results can no longer trigger the expected Codex install elicitation.
Useful? React with 👍 / 👎.
Why
With the extension and core backend in place, core can expose the plural tool while preserving Noah's original install picker behavior.
What changed
request_plugin_installsthrough the extension executorThe emitted picker metadata remains the original nested
entries/categoriescontract, including per-entry Install buttons and the Skip / Continue footer.Stack
This is PR 6 of 7.