Add plugin install extension backend#28818
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcbff1ea06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| codex-network-proxy = { workspace = true } | ||
| codex-otel = { workspace = true } | ||
| codex-plugin = { workspace = true } | ||
| codex-plugin-installs-extension = { workspace = true } |
There was a problem hiding this comment.
Adding codex-plugin-installs-extension to codex-core changes the Rust dependency graph, but this commit only updates Cargo.toml/Cargo.lock and leaves MODULE.bazel.lock out of the diff. Bazel CI runs the lockfile check in error mode, so this will fail with lockfile drift until just bazel-lock-update is run from the repo root and the resulting MODULE.bazel.lock update is committed.
AGENTS.md reference: AGENTS.md:L37-L40
Useful? React with 👍 / 👎.
| refresh_missing_requested_connectors( | ||
| session, | ||
| turn, | ||
| auth, | ||
| &expected_connector_ids, | ||
| REQUEST_PLUGIN_INSTALLS_TOOL_NAME, |
There was a problem hiding this comment.
When a picker contains a direct connector plus a plugin whose app_connector_ids have not appeared yet, this passes one combined expected connector list into the refresh helper. If the hard refresh then errors, refresh_missing_requested_connectors returns None, so the later per-entry check marks even a direct connector that was already accessible in the pre-refresh cache as incomplete. That makes successful connector installs look failed whenever an unrelated plugin connector is missing and the refresh endpoint hiccups; verify direct connector entries independently or keep the pre-refresh connector list on refresh failure.
Useful? React with 👍 / 👎.
1 participant
Why
Core still owns session-specific work such as elicitation, config persistence, connector refresh, plugin verification, and telemetry. This layer adapts those host operations to the extension boundary without registering a new tool yet.
What changed
CoreRequestPluginInstallsBackendStack
This is PR 5 of 7.