Skip to content

feat: Add form library and split views - #367

Merged
lornakelly merged 1 commit into
open-workflow-specification:feature/node-editingfrom
lornakelly:359/add-form-library
Aug 28, 2026
Merged

feat: Add form library and split views#367
lornakelly merged 1 commit into
open-workflow-specification:feature/node-editingfrom
lornakelly:359/add-form-library

Conversation

@lornakelly

@lornakelly lornakelly commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Closes: #359

Adds react-hook-form and splits node properties section into separate read only and editable branches so isReadOnly prop is read once.

NOTE: both branches currently render the same behaviour. This work is in preparation for editing state

Changes

  • Added ReadOnlyProperties
  • Added EditableProperties - placeholder for the editable view. For now, it just displays ReadOnlyProperties
  • NodeDetailsView reads isReadOnly once and branches; the local FieldRow wrapper is gone.
  • Removed isReadOnly from PropertyField and all nine leaf controls.

Signed-off-by: lornakelly <lornakelly88@gmail.com>
@netlify

netlify Bot commented Aug 28, 2026

Copy link
Copy Markdown

Deploy Preview for openworkflow-editor ready!

Name Link
🔨 Latest commit 21da49a
🔍 Latest deploy log https://app.netlify.com/projects/openworkflow-editor/deploys/6a916142b639700008fa4f6c
😎 Deploy Preview https://deploy-preview-367--openworkflow-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@handreyrc handreyrc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lornakelly,

Pretty staightforward, LGTM.

Thanks for your work!

@lornakelly
lornakelly merged commit 95127b3 into open-workflow-specification:feature/node-editing Aug 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants