fix: ReadOnlyProperties view - #371
Open
lornakelly wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for openworkflow-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the side-panel “Properties” rendering so read-only properties are presented as static text/shape summaries (not disabled form controls), aligning the UI with the new ReadOnlyProperties view direction from #367.
Changes:
- Replaces property-row rendering with a static
PropertyValuepresenter (including long-string blocks and array/object shape placeholders). - Adds/updates CSS to support monospace value rendering and long-value blocks.
- Adds dedicated
ReadOnlyPropertiestests and updatesNodeDetailsViewtests to assert text-based rendering.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/open-workflow-diagram-editor/tests/side-panel/ReadOnlyProperties.test.tsx | Adds focused coverage for static rendering across all DetailField kinds. |
| packages/open-workflow-diagram-editor/tests/side-panel/NodeDetailsView.test.tsx | Updates assertions from disabled controls to literal text; adds “no form controls” expectation. |
| packages/open-workflow-diagram-editor/src/styles.css | Introduces a shared --dec-font-mono CSS variable. |
| packages/open-workflow-diagram-editor/src/side-panel/SidePanel.css | Styles for .dec-sidebar-value* and long-value blocks; switches error field to use --dec-font-mono. |
| packages/open-workflow-diagram-editor/src/side-panel/Fields.tsx | Implements PropertyValue and routes PropertyField to use it instead of form controls. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: lornakelly <lornakelly88@gmail.com>
lornakelly
force-pushed
the
read-only-fields
branch
from
August 28, 2026 15:57
cecd64f to
545d64c
Compare
lornakelly
requested review from
cheryl7114,
fantonangeli,
handreyrc and
kumaradityaraj
August 28, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing on from #367
The new
ReadOnlyPropertiesis the dedicated view for whenisReadOnlyprop is true (MVP).Currently the read only fields are displayed as different field controls disabled. This PR addresses this and displays read only fields as they should be displayed. Initially we implemented so that the same fields would switch from read only to editing but after design sessions it is better to keep them completely separate
Before
After
