[CONFIGURATION] File configuration - resource detectors#4113
Open
rishitha957 wants to merge 2 commits into
Open
[CONFIGURATION] File configuration - resource detectors#4113rishitha957 wants to merge 2 commits into
rishitha957 wants to merge 2 commits into
Conversation
Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.net>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4113 +/- ##
==========================================
- Coverage 81.95% 81.77% -0.18%
==========================================
Files 385 388 +3
Lines 16067 16105 +38
==========================================
+ Hits 13166 13168 +2
- Misses 2901 2937 +36
🚀 New features to boost your workflow:
|
marcalff
changed the title
3 tasks
marcalff
reviewed
Jun 5, 2026
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the draft.
This looks good so far and has a very good structure.
Please add unit tests for resource detection, it will help to make progress.
| public: | ||
| std::unique_ptr<AttributesConfiguration> attributes; | ||
| std::unique_ptr<IncludeExcludeConfiguration> detectors; | ||
| std::unique_ptr<ResourceDetectionConfiguration> detection; |
Member
There was a problem hiding this comment.
New member detection looks ok.
Please remove the existing member detectors, it was misplaced and does not comply with the yaml schema.
Comment on lines
+2566
to
+2581
| for (auto it = node->begin_properties(); it != node->end_properties(); ++it) | ||
| { | ||
| std::string name = it.Name(); | ||
|
|
||
| if (name == "container") | ||
| { | ||
| return std::make_unique<ContainerResourceDetectorConfiguration>(); | ||
| } | ||
| else | ||
| { | ||
| auto extension = std::make_unique<ExtensionResourceDetectorConfiguration>(); | ||
| extension->name = name; | ||
| extension->node = it.Value(); | ||
| return extension; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
It is weird to have a for loop and return from the middle of it.
Please check for example ConfigurationParser::ParseLogRecordProcessorConfiguration() for the pattern.
Member
|
Current IWYU failure in CI: |
Member
|
Thanks for the PR. Setting as ready for review, please check my comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3916
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes