Skip to content

Adding the required declarative specifications#4125

Open
om7057 wants to merge 3 commits into
open-telemetry:mainfrom
om7057:fix/experimental-resource-detection-config
Open

Adding the required declarative specifications#4125
om7057 wants to merge 3 commits into
open-telemetry:mainfrom
om7057:fix/experimental-resource-detection-config

Conversation

@om7057
Copy link
Copy Markdown

@om7057 om7057 commented Jun 5, 2026

Fixes #3916

Changes

Adds the experimental declarative resource detection model to the YAML configuration parser, including support for detection/development.resource.detectors entries for container, host, process, and service. Also adds unit tests covering the new configuration shape.

For significant contributions, please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@om7057 om7057 requested a review from a team as a code owner June 5, 2026 18:17
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jun 5, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: om7057 / name: om7057 (3d7f54e)

@marcalff
Copy link
Copy Markdown
Member

marcalff commented Jun 5, 2026

@om7057

Thanks for the contribution.

Beware, this is a duplicated effort with PR #4113

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

❌ Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.01%. Comparing base (b706b56) to head (3d7f54e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/configuration/configuration_parser.cc 82.23% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4125      +/-   ##
==========================================
+ Coverage   82.01%   82.01%   +0.01%     
==========================================
  Files         385      385              
  Lines       16031    16076      +45     
==========================================
+ Hits        13146    13183      +37     
- Misses       2885     2893       +8     
Files with missing lines Coverage Δ
sdk/src/configuration/configuration_parser.cc 76.34% <82.23%> (+0.20%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff added the duplicate This issue or pull request already exists label Jun 5, 2026
@om7057
Copy link
Copy Markdown
Author

om7057 commented Jun 6, 2026

Sure, I've updated the PR with better coverage. Could you please check once @marcalff ?

@marcalff
Copy link
Copy Markdown
Member

marcalff commented Jun 6, 2026

Sure, I've updated the PR with better coverage. Could you please check once @marcalff ?

Thanks for your interest, but this really is duplicate work with #4113, which is already under review.

If you would like to contribute in this area (file configuration and yaml), please take a look at #4130 instead.

@om7057
Copy link
Copy Markdown
Author

om7057 commented Jun 6, 2026

Sure, I've updated the PR with better coverage. Could you please check once @marcalff ?

Thanks for your interest, but this really is duplicate work with #4113, which is already under review.

If you would like to contribute in this area (file configuration and yaml), please take a look at #4130 instead.

Ok sure, will take that issue up to resolve and send a PR with the changes.
Thank you for your consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CONFIGURATION] File configuration - resource detectors

2 participants