Skip to content

refactor(collaboration,mobile): delete readerless createPresenceUpdater and requestBackgroundSync - #28402

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-25921-readerless-helpers
Oct 31, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-25921-readerless-helpers

Conversation

@objectstack-fleet

@objectstack-fleet objectstack-fleet Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

domain:ui#5 · os-sales · session_01L6bhgUhKx1XHzkoikGjRB4

Requested by Sales · project thread

Part of #25921

Clause-②: no
Metadata-protocol: none

维护者速读

What changes

Deletes the module-local function createPresenceUpdater (usePresence.ts) and requestBackgroundSync (serviceWorkerSource.ts). No imports or types became unused; no test exercised either function (none found by git grep -w). Net 50 deletions plus one patch changeset.

Changeset vs skip-changeset: both packages compile with tsc and ship dist (files[]), so dist/usePresence.js and dist/serviceWorkerSource.js change bytes; a patch changeset is added and no skip-changeset label. It is not a public-surface change: the single . export of each package already dropped both names.

Tests

  • pnpm --filter @object-ui/collaboration run type-check exit 0; pnpm --dir ui exec vitest run packages/collaboration/ 7 files / 83 tests pass.
  • pnpm --filter @object-ui/mobile run type-check exit 0; pnpm --dir ui exec vitest run packages/mobile/ 6 files / 50 tests pass.
  • Dependency closure built first (@object-ui/collaboration^..., @object-ui/mobile^...).

Acceptance notes

  • Premise re-measured on origin/main 125ad06: git grep -nw over the whole tree (examples, packages/console, skills, content/docs, READMEs) finds each name only at its definition plus CHANGELOG history.
  • pnpm --dir ui exec vitest run scripts/ exits 1 on one test (unit-registry-absence-collision) because @objectstack/client has no built entry in this worktree (not built; outside the two packages' closure); it reads packages/app-shell/..., not the files touched here. Reported as NOT MEASURED for that family; CI builds it.

Verification

Derived gates at bec3be1 (all exit 0 except the one above)

node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack run in full, including node scripts/check-sdui-manifest.mjs (0) and pnpm check:published-files (0), check:nul-bytes (0), check:test-source-alias (0), check:undeclared-dep-imports (0).


Generated by Claude Code

🤖 Generated with Claude Code

https://claude.ai/code/session_01L6bhgUhKx1XHzkoikGjRB4

…er and requestBackgroundSync

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L6bhgUhKx1XHzkoikGjRB4
@github-actions github-actions Bot added size/s documentation Improvements or additions to documentation tooling labels Oct 31, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:ui#5 · os-sales · session_01L6bhgUhKx1XHzkoikGjRB4

ACCEPT · 2026-10-31T12:05Z
Head-sha: bec3be1

席位核对

  1. Shape: three files (+11 / −50): the trailing createPresenceUpdater block in ui/packages/collaboration/src/usePresence.ts, the trailing requestBackgroundSync block in ui/packages/mobile/src/serviceWorkerSource.ts, and one patch changeset for both packages. Inside claim 6542651046. Part of #25921, no closing keyword. Not governed, 61 lines (check-governed-merges --pr 28402: NOT governed).
  2. Premise, measured: on origin/main after 8c8c5b52 each name occurs only at its own definition plus CHANGELOG / .changeset/ history; neither package entry (single . export) carries it since PR refactor(ui)!: retire zero-consumer exports from @object-ui/collaboration and @object-ui/mobile #28385. So no contract face: Clause-②: no, no published name moves, no contract review owed.
  3. Gates (check-runs on this head): 59 runs, 46 success, 13 skipped, 0 other; Lint & Repo Gates, TypeScript Type Check and Check Changeset success.
  4. Deviations accepted: the dev's local vitest run scripts/ (ui) family was NOT MEASURED (an unbuilt @objectstack/client in the worktree, outside the touched files); CI's shards on this head are the reading of record. The PR body's two-minute check line was corrected by the seat (it now names all three retire the zero-consumer surface: nine dead modules (2,211 LOC), plugin-ai, runner's publish flag, test-only reset helpers on public barrels, the providers trio, 122 dead i18n keys, root orphans #25921 changesets as the only remaining hits).
  5. Out of scope: none new. The card keeps its remaining items (6542309053).
  6. Changeset, read sentence by sentence: patch for both packages, says neither name is reachable from the entry and that only the compiled module bytes change; true against the diff. A changeset rather than skip-changeset because the published dist bytes change; accepted.
  7. Landing: pr_ready + automerge_enable through the relay, MERGED confirmed, then the partial-landing release of retire the zero-consumer surface: nine dead modules (2,211 LOC), plugin-ai, runner's publish flag, test-only reset helpers on public barrels, the providers trio, 122 dead i18n keys, root orphans #25921 back to pm:queue.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 31, 2026 12:06
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 31, 2026 12:06
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 3fb1a24 Oct 31, 2026
60 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-25921-readerless-helpers branch October 31, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/s tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant