Repository navigation
test(ui): pin the 19th flow value-ledger entry, connector_action input.* - #28193
Merged
Merged
Conversation
…t.*) The expression ledger gained a `value` entry rooted in `connectorConfig` (`connector_action` `input.*`); the flow value-envelope test pinned the old 18-entry list. Add the entry; the six-map offer assertion is unchanged. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L9qibviuUXqPDLL8ToR4Nm
Contributor
Author
|
domain:ui#3 · os-tesla · session_01L9qibz8HEj53Wx2uphTo2o 维护者速读
席位意见:一行测试钉子随账本更新,根因在卡上已核实,p0 修复前进,可直接落地。 席位核对ACCEPT · seat
|
This was referenced Oct 30, 2026
os-bill
pushed a commit
that referenced
this pull request
Oct 31, 2026
Brings in #27713 (one request opens a record page) and #28193 (the 19th flow value-ledger entry), both landed after this branch's base. Claude-Session: https://claude.ai/code/session_01Utp6CaA9ZdTcj97mzGtHYt Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tesla · project thread
Fixes #28185
Fixes #28184
Clause-②: no
Metadata-protocol: none
维护者速读
connector_action:input.*,并在注释里说明它来自 automation: registration does not judge aconnector_actionnode'sconnectorConfig.inputvalue slot, because the spec expression ledger cannot address a sibling block ofconfig#27968 / fix(spec,service-automation,lint)!: registration and validate judge a connector_action's connectorConfig.input value slot #28150。main上Test UI变红,合并队列里的每个 PR 都被踢出。ui/packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts第 71–82 行。pnpm --dir ui exec vitest run packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts,预期 11/11 通过。What changes
flow-value-envelope.test.ts, case "offers the envelope on exactly the six hand-table key/value maps the ledger names": the expectedvalue-role list ofFLOW_NODE_EXPRESSION_PATHSgains'connector_action:input.*'(sorted, betweenassignment:assignments.*andcreate_record:fields.*), and the comment above it says the list grew at #27968 / #28150 with the one entry rooted inconnectorConfig. The six-mapofferedassertion is unchanged:isValueEnvelopeSlotanswers only forconfig-rooted maps.Tests
Red on origin/main c48cd2c → green with the fix
Verification
dispatch-gates --commands, re-derived against this diff
Acceptance notes
@object-ui/app-shellis private and itsfiles[](dist,src/styles.css, README, CHANGELOG, LICENSE) does not ship test sources, so the diff publishes nothing;skip-changesetrides the create.connectorConfig.inputstays with Studio connector_action form shows no envelope editor and no in-form refusal for a template token in connectorConfig.input #28164 (blocked); this PR does not touch it.🤖 Generated with Claude Code
https://claude.ai/code/session_01L9qibviuUXqPDLL8ToR4Nm