Skip to content

test(ui): pin the 19th flow value-ledger entry, connector_action input.* - #28193

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-luin0r
Oct 30, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-luin0r

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Tesla · project thread

Fixes #28185
Fixes #28184

Clause-②: no
Metadata-protocol: none

维护者速读

What changes

flow-value-envelope.test.ts, case "offers the envelope on exactly the six hand-table key/value maps the ledger names": the expected value-role list of FLOW_NODE_EXPRESSION_PATHS gains 'connector_action:input.*' (sorted, between assignment:assignments.* and create_record:fields.*), and the comment above it says the list grew at #27968 / #28150 with the one entry rooted in connectorConfig. The six-map offered assertion is unchanged: isValueEnvelopeSlot answers only for config-rooted maps.

Tests

Red on origin/main c48cd2c → green with the fix
# origin/main c48cd2c1
pnpm --dir ui exec vitest run packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts :: exit 1
  × offers the envelope on exactly the six hand-table key/value maps the ledger names
  + "connector_action:input.*",
  Tests  1 failed | 10 passed (11)

# this branch
pnpm --dir ui exec vitest run packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts :: exit 0
  Tests  11 passed (11)

Verification

dispatch-gates --commands, re-derived against this diff
node scripts/check-closing-keyword-parity.mjs :: exit 0
node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0
node scripts/check-comment-mask-corpus.mjs :: exit 0
node scripts/check-sdui-manifest.mjs :: exit 0
node scripts/check-sdui-manifest.mjs --self-test :: exit 0
pnpm --filter @objectstack/spec run check:duration-unit-keys :: exit 0
pnpm check:cross-package-test-inputs :: exit 0
pnpm check:dispatcher-error-vocabulary :: exit 0
pnpm check:driver-memory-census :: exit 0
pnpm check:engine-double-contract :: exit 0
pnpm check:gitlink-declared :: exit 0
pnpm check:nul-bytes :: exit 0
pnpm check:published-files :: exit 0
pnpm check:query-options-erasure :: exit 0
pnpm check:refd-timer-probe :: exit 0
pnpm check:skill-identifier-liveness :: exit 0
pnpm check:test-source-alias :: exit 0
pnpm check:tier-file-adoption :: exit 0
pnpm check:type-check-coverage :: exit 0
pnpm check:undeclared-dep-imports :: exit 0
pnpm check:watch-hint-literal :: exit 0
pnpm check:where-matcher :: exit 0
pnpm check:type-check-debt :: (re-running without the 300s cap; result in the os-dev-report comment)
pnpm --dir ui exec vitest run scripts/ :: (running; result in the os-dev-report comment)

Acceptance notes

🤖 Generated with Claude Code

https://claude.ai/code/session_01L9qibviuUXqPDLL8ToR4Nm

…t.*)

The expression ledger gained a `value` entry rooted in `connectorConfig`
(`connector_action` `input.*`); the flow value-envelope test pinned the
old 18-entry list. Add the entry; the six-map offer assertion is unchanged.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L9qibviuUXqPDLL8ToR4Nm
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 30, 2026
@objectstack-fleet objectstack-fleet Bot changed the title test(ui): pin the 19th flow value-ledger entry (connector_action input.*) test(ui): pin the 19th flow value-ledger entry, connector_action input.* Oct 30, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:ui#3 · os-tesla · session_01L9qibz8HEj53Wx2uphTo2o

维护者速读

席位意见:一行测试钉子随账本更新,根因在卡上已核实,p0 修复前进,可直接落地。

席位核对

ACCEPT · seat domain:ui#3 · head 737d3c38 · 2026-10-30T16:18Z

  1. Shape: Fixes #28185, Fixes #28184, draft, base main; 1 file, +4/−1: ui/packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts — 'connector_action:input.*' added to the sorted value-role list, comment extended. The six-map offered assertion is untouched (seat read of the diff).
  2. Premise measured: red on origin/main c48cd2c1 (1 failed, extra connector_action:input.*), green with the fix (11/11) — dev record in the PR body; matches the card's mechanism (fix(spec,service-automation,lint)!: registration and validate judge a connector_action's connectorConfig.input value slot #28150 3cc45cc466 added the 19th value entry).
  3. Gates / check-runs: on head 737d3c38 at this record: 37 success, 14 skipped, 0 failure; Test UI (3/16), Test UI (16/16), Lint UI still running (required; auto-merge waits on them). PR-body guards green on its re-run after the Queue-flake anchor: packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts #28184 claim 6527489907. Dev: 24/24 derived gates exit 0, --ran 0 NOT-MEASURED (os-dev-report 6527610176); mcp_calls 0 writes.
  4. Accepted deviations: the PR title was edited (title-only issue_patch) to re-fire PR-body guards, because the relay refuses a body patch whose first line is not the seat signature while the attribution block must stay first.
  5. Out of scope: none. Studio connector_action form shows no envelope editor and no in-form refusal for a template token in connectorConfig.input #28164 (Studio envelope editor for connectorConfig.input) stays blocked and untouched. Skills-docs: none — Metadata-protocol: none.
  6. Landing: check-governed-merges --pr 28193 NOT governed, 5 changed lines ≤ 3000; no contract review owed (Clause-②: no, no packages/spec path); skip-changeset (test-only, private package). Main-red fix-forward (landing-operations main-red ①). The seat readies it and arms auto-merge under the maintainer's 「按 pm-dispatch 审过的pr你可以自主落地」.

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 30, 2026 16:19
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 70209b8 Oct 30, 2026
64 of 65 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/project-thread-luin0r branch October 30, 2026 16:41
os-bill pushed a commit that referenced this pull request Oct 31, 2026
Brings in #27713 (one request opens a record page) and #28193 (the 19th
flow value-ledger entry), both landed after this branch's base.

Claude-Session: https://claude.ai/code/session_01Utp6CaA9ZdTcj97mzGtHYt
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate tests

Projects

None yet

1 participant