Repository navigation
test(ui): the Automations Problems double serves the draft door's node path (#28192) - #28227
Merged
Merged
Conversation
…e path Since the lint pass gave a flow node's config-value finding its slot key path (flows[0].nodes[1].config.fields.id), the test's draft-read double passed that stack spelling straight into `_diagnostics`, so the Problems row showed the raw path. The real door re-spells it item-relative (nodes.1.config.fields.id) in itemRelativeIssuePath; the double now does the same, and the row is located at the node itself, so the target pin reads the node's name and id. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L9qibvQ7smY6Y87y1pRDaY
Contributor
Author
|
domain:ui#3 · os-tesla · session_01L9qibz8HEj53Wx2uphTo2o 维护者速读
席位意见:根因已核实,替身逐行对照服务端改写函数,测试主旨「节点格与问题行用同样的话」不变,p0 修复前进,可直接落地。 席位核对ACCEPT · seat
|
This was referenced Oct 30, 2026
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tesla · project thread
Clause-②: no
Metadata-protocol: none
Fixes #28219
维护者速读
nodes.1.config.fields.id)。flows[0].nodes[1].config.fields.id;真实草稿接口会把它改写成条目相对路径,但测试替身直接透传原始路径,导致 main 上Test UI (13/16)一直红、合并队列不断踢出 PR。itemRelative(对照packages/metadata-protocol/src/metadata-diagnostics.ts的itemRelativeIssuePath),以及重新钉住的两行断言。pnpm --dir ui exec vitest run packages/app-shell/src/views/studio-design/AutomationsPillar.problemsAgree-27799.test.tsx,预期 3 条全过。What changed
draftVerdictin the test's server double built_diagnosticsfromvalidateStackExpressionswithpath: i.path ?? i.where. Since #28192 (3efccfd5) a node config-value finding carriespath: 'flows[0].nodes[1].config.fields.id'. The real draft door re-spells a gate path found on the written item to the dotted item-relative form initemRelativeIssuePath(packages/metadata-protocol/src/metadata-diagnostics.tsL388–400, called fromwithPublishVerdictL422; pinned by the[#27828]case inprotocol.draft-publish-verdict.test.tsL466,nodes.1.config.fields.name). That helper is not exported and@object-ui/app-shelldoes not depend on metadata-protocol, so the double mirrors it (fortype: 'flow', prefixflows[0]) and cites the line.With the door's spelling the Problems row is located at the node itself:
targetLabel(ProblemsPanel.tsxL54–57) renders the node's display nameWritewith the node id astitle. Before #28192 the row fell back to thewhereprose (node 'write' … config.fields.id), which is what L211–212 pinned. They are re-pinned to the node-located shape. The case's subject is unchanged: the row still reads the cell's own refusal,NEEDED()(the assertion before the target pins, which stayed green throughout).Verification
origin/main@7811c3f6(≥3efccfd5):AssertionError: expected 'flows[0].nodes[1].config.fields.id' to contain 'node \'write\''— 1 failed | 2 passed.3efccfd5^: by reasoning from L62, not a second build — before fix(lint): a flow node config-value finding carries the slot's key path, so Studio's Problems row selects the node #28192 lint gave a node config finding nopath, soi.path ?? i.whereserved thewhereprose that L211–212 pinned.expected 'Write' to contain 'node \'write\''— the row names the node by its label; cell and row agree.path: i.path ?? i.whererestored verbatim ⇒ reds again withReceived: "flows[0].nodes[1].config.fields.id"; fix restored,git diff HEADempty.dispatch-gates.mjs --commandsderived 24 commands for this one file; ran record below.Ran record (in progress; completed record follows in the os-dev-report): 14 of 24 exit 0 so far;
pnpm --dir ui exec vitest run scripts/exit 1 (7 tests in 2 files, under triage against main — this diff touches no script).Acceptance notes
@object-ui/app-shellis private and itsfiles[]ships no test sources, so the diff publishes nothing;skip-changesetrides the create (as test(ui): pin the 19th flow value-ledger entry, connector_action input.* #28193 did).3efccfd5is needed.🤖 Generated with Claude Code
https://claude.ai/code/session_01L9qibvQ7smY6Y87y1pRDaY