fix: Updated transformer to prevent instrumenting a non-existent method on a class#59
Merged
bizob2828 merged 3 commits intonodejs:mainfrom Apr 7, 2026
Merged
fix: Updated transformer to prevent instrumenting a non-existent method on a class#59bizob2828 merged 3 commits intonodejs:mainfrom
bizob2828 merged 3 commits intonodejs:mainfrom
Conversation
bizob2828
requested review from
AbhiPrasad,
Qard,
jsumners-nr,
rochdev and
timfish
AbhiPrasad
approved these changes
Apr 6, 2026
jsumners-nr
approved these changes
Apr 7, 2026
Contributor
jsumners-nr
left a comment
jsumners-nr
left a comment
There was a problem hiding this comment.
I like the boolean return. We just need to eliminate these unnecessary headers.
jsumners-nr
reviewed
Apr 7, 2026
jsumners-nr
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the js rewrite occurred in #41 there was code to handle wrapping a method on the base class. This didn't take into account if the method actual existed so it wrote a wrapper that basically did nothing. This PR fixes it by skipping instrumenting when a methodName does not exist on a class or any sub classes