Samtools mpileup input update#9810
Merged
Krannich479 merged 14 commits intonf-core:masterfrom Feb 2, 2026
Merged
Conversation
SPPearce
reviewed
Jan 31, 2026
matthdsm
reviewed
Feb 2, 2026
matthdsm
reviewed
Feb 2, 2026
matthdsm
reviewed
Feb 2, 2026
Contributor
Author
|
With commit 59c4331 :
|
matthdsm
reviewed
Feb 2, 2026
matthdsm
reviewed
Feb 2, 2026
| @@ -49,7 +49,7 @@ input: | |||
| description: FASTA reference file. Optional. | |||
Contributor
There was a problem hiding this comment.
fasta will also be required when using cram inputs, but that's implied and known when using cram data I guess
matthdsm
approved these changes
Feb 2, 2026
Contributor
matthdsm
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for wading through all the input
Contributor
Author
|
Thank you for all your valuable feedback! |
Contributor
Author
|
I leave this here for documentation: |
cavenel
pushed a commit
to cavenel/modules
that referenced
this pull request
Feb 5, 2026
* new input layout; samtools version bump * tests for new input layout * fix linting issues * prettier shenanigans in CI * Fix formatting and indentation in main.nf.test * change input layout to one large tuple for all sample related input * added faidx optional input parameter * tiny name fix * tiny name fix in meta too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #9802
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile condaAn extensive description of why I believe a new input section is necessary can be found in #9802 .