Update Rundbcan modules #9768
Merged
Xinpeng021001 merged 10 commits intonf-core:masterfrom Feb 3, 2026
Merged
Conversation
mashehu
reviewed
Jan 26, 2026
Comment on lines
108
to
113
| [ | ||
| { | ||
| "id": "test" | ||
| }, | ||
| "test_dbCANsub_hmm_results.tsv:md5,7ce7b6536845ffa8907b3f3fb2b77a1b" | ||
| ] |
Contributor
There was a problem hiding this comment.
is this empty output expected with the version update?
Contributor
Author
There was a problem hiding this comment.
Yes, the software updates output logic a bit. @Xinpeng021001 Could you explain the reason here?
Member
There was a problem hiding this comment.
@mashehu hi, based on the test data we have on nf-core, we cannot generate the expected results, and that's why we create the empty output. We use HMMdbs for the run_dbcan which is strict to get results.
Member
There was a problem hiding this comment.
I'm working on a new version and once it is merged I'll add it as the newest version here.
Xinpeng021001
approved these changes
Feb 3, 2026
11 tasks
cavenel
pushed a commit
to cavenel/modules
that referenced
this pull request
Feb 5, 2026
* update rundbcan modules * make dbCAN substrate output optional * make dbCAN easyCGC and easySubstrate work as well * make output optional * update snapshot * update to 5.2.5 * update to 5.2.6 * fix bugs * update the snap files --------- Co-authored-by: Xinpeng Zhang <84593788+Xinpeng021001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the rundbcan modules from v5.1.2 to v5.2.4.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda