miniasm/ updated to use the new versions topics#9755
Merged
jdc-eit merged 10 commits intonf-core:masterfrom Feb 2, 2026
Merged
miniasm/ updated to use the new versions topics#9755jdc-eit merged 10 commits intonf-core:masterfrom
jdc-eit merged 10 commits intonf-core:masterfrom
Conversation
MohineTAlam
changed the title
mashehu
approved these changes
Jan 22, 2026
mashehu
previously requested changes
Jan 22, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Contributor
|
btw. if you join the nf-core org, tests will start automatically: https://nf-co.re/docs/contributing/how_to_contribute_to_nf-core#joining-the-slack-and-github-organisations |
Contributor
Author
|
@nf-core-bot fix linting |
mashehu
reviewed
Jan 23, 2026
mashehu
reviewed
Jan 23, 2026
mashehu
reviewed
Jan 23, 2026
MohineTAlam
commented
Jan 24, 2026
Contributor
Author
MohineTAlam
left a comment
MohineTAlam
left a comment
There was a problem hiding this comment.
Thank you for the edits, this is my first nf-core contributions, so sorry for the hassle!
change fastqc to miniasm - leftover boilerplate
vagkaratzas
approved these changes
Feb 2, 2026
eit-maxlcummins
dismissed
mashehu’s stale review
Already reviewed by @vagkaratzas
cavenel
pushed a commit
to cavenel/modules
that referenced
this pull request
Feb 5, 2026
* updated versions * Update modules/nf-core/miniasm/meta.yml Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com> * Apply suggestion from @mashehu * Apply suggestion from @mashehu * Apply suggestion from @mashehu * Update meta.yml change fastqc to miniasm - leftover boilerplate --------- Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com> Co-authored-by: eit-maxlcummins <mcummins@eit.org> Co-authored-by: Julio DiazCaballero <jdiaz@eit.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meta.yml, main.nf, and main.test.snap updated to the new versions topics <!--
nf-core/modules pull request
Many thanks for contributing to nf-core/modules!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
Remember that PRs should be made against the master branch.
Learn more about contributing: CONTRIBUTING.md
-->
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda